Skip to content

Add created by me filter#1713

Open
Mbeaulne wants to merge 1 commit intomasterfrom
01-27-add_created_by_me_filter
Open

Add created by me filter#1713
Mbeaulne wants to merge 1 commit intomasterfrom
01-27-add_created_by_me_filter

Conversation

@Mbeaulne
Copy link
Collaborator

@Mbeaulne Mbeaulne commented Jan 27, 2026

Description

Added a new CreatedByFilter component that allows filtering content by creator. The component includes:

  • A toggle switch for "Created by me" functionality
  • A search input for filtering by specific usernames
  • Comprehensive test coverage for all component behaviors

NOTE: This feature does get changed down the stack to a better UI/UX in my opinion.

Type of Change

  • New feature
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

The component renders a toggle switch with "Created by me" label and a search input with a search button

Test Instructions

  1. Toggle the switch to filter by current user
  2. Enter a username in the search field and click "Search" to filter by specific user
  3. Verify the component correctly displays the current filter state

Additional Comments

The component supports two main use cases:

  • Quick filtering by current user with the toggle
  • Specific user filtering with the search input
  • The value can be undefined (no filter), "me" (current user), or any username

Copy link
Collaborator Author

Mbeaulne commented Jan 27, 2026

@Mbeaulne Mbeaulne changed the base branch from 01-27-status_filter to graphite-base/1713 January 27, 2026 18:49
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from ec26c4a to e23f4b0 Compare January 27, 2026 18:49
@Mbeaulne Mbeaulne changed the base branch from graphite-base/1713 to 01-27-filter_bar January 27, 2026 18:50
@Mbeaulne Mbeaulne changed the base branch from 01-27-filter_bar to graphite-base/1713 January 27, 2026 18:51
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from e23f4b0 to 28071c7 Compare January 27, 2026 18:52
@Mbeaulne Mbeaulne changed the base branch from graphite-base/1713 to 01-27-status_filter January 27, 2026 18:52
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from 28071c7 to d1ebf96 Compare January 27, 2026 18:57
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch 2 times, most recently from 5e51976 to c6a465d Compare January 28, 2026 20:46
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from d1ebf96 to 08c0320 Compare January 28, 2026 20:46
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch from c6a465d to 97c09af Compare February 2, 2026 19:32
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from 08c0320 to d3185c3 Compare February 2, 2026 19:32
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch from 97c09af to b85a348 Compare February 2, 2026 19:33
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from d3185c3 to 5b0bea0 Compare February 2, 2026 19:33
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch from b85a348 to bd92e2d Compare February 2, 2026 20:31
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from 5b0bea0 to 36a4057 Compare February 2, 2026 20:31
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch from bd92e2d to b9286f8 Compare February 2, 2026 20:46
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from 36a4057 to 766de30 Compare February 2, 2026 20:46
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch 2 times, most recently from 2441f6b to f0bf8ba Compare February 10, 2026 15:04
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from 2558d71 to c463ef7 Compare February 10, 2026 15:05
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch from f0bf8ba to 9a9b83c Compare February 10, 2026 15:36
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from c463ef7 to 27ae5ae Compare February 10, 2026 15:37
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch from 9a9b83c to 2e660dd Compare February 10, 2026 17:00
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from 27ae5ae to 5f62ff6 Compare February 10, 2026 17:00
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch from 2e660dd to d7a5668 Compare February 10, 2026 17:22
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from 5f62ff6 to 3c7ea8c Compare February 10, 2026 17:22
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from 3c7ea8c to aa8b103 Compare February 17, 2026 15:45
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch 2 times, most recently from 6dc36af to 788a7b8 Compare February 17, 2026 16:00
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from aa8b103 to 91f30a0 Compare February 17, 2026 16:00

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions:
How reliable is this "me". Is this really the value we use in our API to represent the current user?

Is there an existing constant we can use?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect to be filtering by an email, or unique id, instead of me

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can filter by email address (e.g. if an email is typed into the search box), but my understanding is that the "filter by me" toggle literally sends the value "me" to the backend.

@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch from 788a7b8 to 4a0365f Compare February 18, 2026 14:58
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from 91f30a0 to 5ed1565 Compare February 18, 2026 14:58
@Mbeaulne Mbeaulne force-pushed the 01-27-status_filter branch 2 times, most recently from bc6599e to 060f9ee Compare February 18, 2026 15:10
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from 5ed1565 to b58c34c Compare February 18, 2026 15:11
@Mbeaulne Mbeaulne requested a review from morgan-wowk February 18, 2026 15:17
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch 2 times, most recently from 7cf059f to ea481af Compare February 18, 2026 15:25
@Mbeaulne Mbeaulne changed the base branch from 01-27-status_filter to graphite-base/1713 February 18, 2026 15:58
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from ea481af to 2129079 Compare February 18, 2026 15:59
@graphite-app graphite-app bot changed the base branch from graphite-base/1713 to master February 18, 2026 15:59
@Mbeaulne Mbeaulne force-pushed the 01-27-add_created_by_me_filter branch from 2129079 to 1675966 Compare February 18, 2026 16:00
@Mbeaulne Mbeaulne requested a review from camielvs February 18, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments