Skip to content

Add filter badge key to active filters badge#1779

Open
Mbeaulne wants to merge 1 commit into02-02-updated_filter_by_me_and_hide_old_filterfrom
02-10-add_filter_badge_key_to_active_filters_badge
Open

Add filter badge key to active filters badge#1779
Mbeaulne wants to merge 1 commit into02-02-updated_filter_by_me_and_hide_old_filterfrom
02-10-add_filter_badge_key_to_active_filters_badge

Conversation

@Mbeaulne
Copy link
Collaborator

@Mbeaulne Mbeaulne commented Feb 10, 2026

Description

Added a new FilterBadgeKey type to improve type safety for filter badge keys in the PipelineRunFiltersBar component. This type defines the specific string literals that can be used as keys for filter badges, including "status", "pipeline_name", "created_by", "date_range", and annotation keys.

Also corrected two filter badge keys to be more consistent:

  • Changed "name" to "pipeline_name"
  • Changed "date" to "date_range"

Type of Change

  • Improvement
  • Cleanup/Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Test Instructions

Verify that the filter badges in the PipelineRunFiltersBar component continue to function correctly, particularly when filtering by pipeline name or date range.

Copy link
Collaborator Author

@Mbeaulne Mbeaulne marked this pull request as ready for review February 10, 2026 18:44
@Mbeaulne Mbeaulne requested a review from a team as a code owner February 10, 2026 18:44
@Mbeaulne Mbeaulne force-pushed the 02-02-updated_filter_by_me_and_hide_old_filter branch from 8d2596d to c6d050b Compare February 10, 2026 18:54
@Mbeaulne Mbeaulne force-pushed the 02-10-add_filter_badge_key_to_active_filters_badge branch from 8eed53a to 8202a47 Compare February 10, 2026 18:54
@Mbeaulne Mbeaulne force-pushed the 02-02-updated_filter_by_me_and_hide_old_filter branch from c6d050b to 9e60811 Compare February 10, 2026 19:35
@Mbeaulne Mbeaulne force-pushed the 02-10-add_filter_badge_key_to_active_filters_badge branch from 8202a47 to 1aa6236 Compare February 10, 2026 19:35
@Mbeaulne Mbeaulne force-pushed the 02-02-updated_filter_by_me_and_hide_old_filter branch from 9e60811 to 514254d Compare February 17, 2026 15:45
@Mbeaulne Mbeaulne force-pushed the 02-10-add_filter_badge_key_to_active_filters_badge branch 2 times, most recently from 0e1d32b to 688c1db Compare February 17, 2026 16:00
@Mbeaulne Mbeaulne force-pushed the 02-02-updated_filter_by_me_and_hide_old_filter branch from 514254d to 2127fd1 Compare February 17, 2026 16:00
@Mbeaulne Mbeaulne force-pushed the 02-02-updated_filter_by_me_and_hide_old_filter branch from 2127fd1 to 20ee0b3 Compare February 18, 2026 15:01
@Mbeaulne Mbeaulne force-pushed the 02-10-add_filter_badge_key_to_active_filters_badge branch from 688c1db to 9662821 Compare February 18, 2026 15:02
@Mbeaulne Mbeaulne force-pushed the 02-02-updated_filter_by_me_and_hide_old_filter branch from 20ee0b3 to c56facb Compare February 18, 2026 15:14
@Mbeaulne Mbeaulne force-pushed the 02-10-add_filter_badge_key_to_active_filters_badge branch from 9662821 to c45ed90 Compare February 18, 2026 15:14
@Mbeaulne Mbeaulne force-pushed the 02-02-updated_filter_by_me_and_hide_old_filter branch from c56facb to a644fef Compare February 18, 2026 15:21
@Mbeaulne Mbeaulne force-pushed the 02-10-add_filter_badge_key_to_active_filters_badge branch from c45ed90 to 0b5f7ce Compare February 18, 2026 15:21
@Mbeaulne Mbeaulne force-pushed the 02-02-updated_filter_by_me_and_hide_old_filter branch from a644fef to eb2db69 Compare February 18, 2026 15:25
@Mbeaulne Mbeaulne force-pushed the 02-10-add_filter_badge_key_to_active_filters_badge branch from 0b5f7ce to 42491fb Compare February 18, 2026 15:25
@Mbeaulne Mbeaulne force-pushed the 02-02-updated_filter_by_me_and_hide_old_filter branch from eb2db69 to ae76830 Compare February 18, 2026 15:31
@Mbeaulne Mbeaulne force-pushed the 02-10-add_filter_badge_key_to_active_filters_badge branch from 42491fb to cec23bf Compare February 18, 2026 15:31
@Mbeaulne Mbeaulne force-pushed the 02-02-updated_filter_by_me_and_hide_old_filter branch from ae76830 to e0e72bc Compare February 18, 2026 15:39
@Mbeaulne Mbeaulne force-pushed the 02-10-add_filter_badge_key_to_active_filters_badge branch 2 times, most recently from 8ce4507 to 79f5641 Compare February 18, 2026 15:40
@Mbeaulne Mbeaulne force-pushed the 02-02-updated_filter_by_me_and_hide_old_filter branch from e0e72bc to a08176a Compare February 18, 2026 15:40
@Mbeaulne Mbeaulne force-pushed the 02-10-add_filter_badge_key_to_active_filters_badge branch from 79f5641 to 311617c Compare February 18, 2026 15:51
@Mbeaulne Mbeaulne force-pushed the 02-02-updated_filter_by_me_and_hide_old_filter branch from a08176a to 309241c Compare February 18, 2026 15:51
@Mbeaulne Mbeaulne force-pushed the 02-10-add_filter_badge_key_to_active_filters_badge branch from 311617c to b49972e Compare February 18, 2026 15:51
@Mbeaulne Mbeaulne force-pushed the 02-02-updated_filter_by_me_and_hide_old_filter branch from 309241c to 4a0de07 Compare February 18, 2026 15:51
@Mbeaulne Mbeaulne force-pushed the 02-10-add_filter_badge_key_to_active_filters_badge branch from b49972e to 4d302de Compare February 18, 2026 15:57
@Mbeaulne Mbeaulne force-pushed the 02-02-updated_filter_by_me_and_hide_old_filter branch 2 times, most recently from 0ad3fd7 to 5ee0045 Compare February 18, 2026 16:02
@Mbeaulne Mbeaulne force-pushed the 02-10-add_filter_badge_key_to_active_filters_badge branch from 4d302de to d443fae Compare February 18, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments