Add useRunSearchParams hook for pipeline run filtering#1704
Merged
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1f60f2c to
57a994f
Compare
This was referenced Jan 27, 2026
Merged
Merged
Open
Draft
8d921a9 to
5de01ff
Compare
This was referenced Feb 2, 2026
5de01ff to
29c1ac2
Compare
29c1ac2 to
1ea6b69
Compare
36a66d1 to
682be80
Compare
d6151d8 to
221b53c
Compare
c9f149a to
0d4873c
Compare
Mbeaulne
commented
Feb 9, 2026
Comment on lines
+87
to
+92
| export function isValidExecutionStatus( | ||
| value: string, | ||
| ): value is ContainerExecutionStatus { | ||
| return value in EXECUTION_STATUS_LABELS; | ||
| } | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
I go back and forth keeping this here or adding it to pipelineRunFilterUtils.
There was a problem hiding this comment.
It is at least only dependent on variables in this same file. So I think it's reasonable to have it here!
I can totally see a case being made to go in either direction. You could say "if it's only used in one place, put it in that one place or don't have a function at all".
Programmer to programmer haha.
0d4873c to
d10ce1d
Compare
morgan-wowk
reviewed
Feb 9, 2026
e774f18 to
fbfb714
Compare
morgan-wowk
reviewed
Feb 9, 2026
morgan-wowk
reviewed
Feb 9, 2026
morgan-wowk
reviewed
Feb 9, 2026
2318f55 to
35bac10
Compare
morgan-wowk
approved these changes
Feb 9, 2026
Collaborator
Author
35bac10 to
f5a1be4
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves: https://github.com/Shopify/oasis-frontend/issues/456
Description
Adds a new
useRunSearchParamshook to manage pipeline run filter state with URL synchronization. This hook provides a clean interface for components to read and update filter parameters while keeping them persisted in the URL.Type of Change
Changes
useRunSearchParamshook with:filters- Current filter state parsed from URLsetFilter/setFilters- Update individual or multiple filterssetFilterDebounced- Debounced filter updates (300ms) for text inputsclearFilters- Reset all filtershasActiveFilters/activeFilterCount- Helper state for UIPipelineRunFiltersandAnnotationFiltertypesChecklist
Test Instructions
This feature has no UI so we can't test yet. If you want to validate it you can use any of the branches above to confirm.
Run the test suite:
npm test src/hooks/useRunSearchParams.test.ts