Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9a6b47d to
e7aedeb
Compare
e7aedeb to
be6fe2f
Compare
57a994f to
8d921a9
Compare
be6fe2f to
3c9b2c8
Compare
8d921a9 to
5de01ff
Compare
3c9b2c8 to
a558f5b
Compare
5de01ff to
6372d73
Compare
1e153d3 to
713cdad
Compare
6372d73 to
6eae7ef
Compare
713cdad to
7e04972
Compare
3e12ed3 to
6b42668
Compare
7e04972 to
1027450
Compare
6b42668 to
a5a3c3b
Compare
981de4d to
b99e21e
Compare
39861d3 to
2af4933
Compare
b99e21e to
22e0cd0
Compare
81c3563 to
fe9c730
Compare
22e0cd0 to
e2dc28d
Compare
e2dc28d to
8ecc3fd
Compare
fe9c730 to
0a49c11
Compare
8ecc3fd to
757b00a
Compare
757b00a to
376ee50
Compare
That is correct. I haven't hooked the API up to the client so things break. Later in the stack you will see that it works. |
376ee50 to
dd5fc17
Compare
|
Any reason to not make it fail gracefully up until the PR where the functionality is actually implemented? In theory we ship this stack as one. But there's a chance we don't... I feel a little icky about having a PR with a known crash in it (even if that crash is fixed later in the stack) |
This is all behind a feature flag that explicitly says its UI only. I think its very low risk, and we will likely launch it all at once anyway |
I Don't think we should be too concerned with "broken" UI since its behind a feature flag and will likely get merged into production at the same time as the rest of the stack
dd5fc17 to
fa22cd0
Compare


Resolves: https://github.com/Shopify/oasis-frontend/issues/462
Description
Adds a date range picker to the pipeline run filters bar for filtering runs by creation date.
Note: This is a UI-only preview. The filters update the URL but are not properly connected to the API, causing a broken search state. This is resolved in a later PR in the stack.
Type of Change
Changes
CalendarandDatePickerWithRangeUI components (shadCN with custom selection colors)PipelineRunFiltersBarDependencies
date-fnsandreact-day-pickerfor date range selectionChecklist
Test Instructions