Skip to content

Date picker#1705

Merged
Mbeaulne merged 1 commit intomasterfrom
01-27-date_picker
Feb 18, 2026
Merged

Date picker#1705
Mbeaulne merged 1 commit intomasterfrom
01-27-date_picker

Conversation

@Mbeaulne
Copy link
Collaborator

@Mbeaulne Mbeaulne commented Jan 27, 2026

Resolves: https://github.com/Shopify/oasis-frontend/issues/462

Description

Adds a date range picker to the pipeline run filters bar for filtering runs by creation date.

Note: This is a UI-only preview. The filters update the URL but are not properly connected to the API, causing a broken search state. This is resolved in a later PR in the stack.

Type of Change

  • New feature

Changes

  • Added Calendar and DatePickerWithRange UI components (shadCN with custom selection colors)
  • Added date range picker to PipelineRunFiltersBar

Dependencies

  • Added date-fns and react-day-picker for date range selection

Checklist

  • I have tested this does not break current pipelines/runs functionality

Test Instructions

  1. Enable the feature flag: Settings → Beta → "Pipeline run filters bar (UI only)"
  2. Navigate to the Runs tab on the home page
  3. Click the date range picker and verify:
    • Calendar popover opens with two months
    • Can select a date range
    • Selection uses the app's edge-selected color
    • Future dates are disabled

Copy link
Collaborator Author

Mbeaulne commented Jan 27, 2026

@Mbeaulne Mbeaulne force-pushed the 01-27-pipeline_run_filters_-_basic branch from 57a994f to 8d921a9 Compare January 27, 2026 18:57
@Mbeaulne Mbeaulne force-pushed the 01-27-pipeline_run_filters_-_basic branch from 8d921a9 to 5de01ff Compare January 28, 2026 20:46
@Mbeaulne Mbeaulne changed the base branch from 01-27-pipeline_run_filters_-_basic to graphite-base/1705 February 2, 2026 20:20
@Mbeaulne Mbeaulne changed the base branch from graphite-base/1705 to 02-02-basic_filter_bar_and_beta_flag February 2, 2026 20:31
@Mbeaulne Mbeaulne force-pushed the 01-27-date_picker branch 2 times, most recently from 1e153d3 to 713cdad Compare February 2, 2026 21:08
@Mbeaulne Mbeaulne force-pushed the 02-02-basic_filter_bar_and_beta_flag branch from 6372d73 to 6eae7ef Compare February 2, 2026 21:08
@Mbeaulne Mbeaulne force-pushed the 02-02-basic_filter_bar_and_beta_flag branch 2 times, most recently from 3e12ed3 to 6b42668 Compare February 2, 2026 21:14
@Mbeaulne Mbeaulne marked this pull request as ready for review February 2, 2026 21:28
@Mbeaulne Mbeaulne requested a review from a team as a code owner February 2, 2026 21:28
@Mbeaulne Mbeaulne force-pushed the 02-02-basic_filter_bar_and_beta_flag branch from 6b42668 to a5a3c3b Compare February 2, 2026 21:50
@Mbeaulne Mbeaulne force-pushed the 02-02-basic_filter_bar_and_beta_flag branch 2 times, most recently from 39861d3 to 2af4933 Compare February 9, 2026 20:56
@Mbeaulne Mbeaulne force-pushed the 02-02-basic_filter_bar_and_beta_flag branch 2 times, most recently from 81c3563 to fe9c730 Compare February 10, 2026 15:03
@Mbeaulne Mbeaulne changed the base branch from 02-02-basic_filter_bar_and_beta_flag to graphite-base/1705 February 10, 2026 15:34
@graphite-app graphite-app bot changed the base branch from graphite-base/1705 to master February 10, 2026 15:35
@Mbeaulne Mbeaulne requested a review from morgan-wowk February 10, 2026 16:30
Copy link
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I select a date the app crashes

image.png

TypeError: filter.split is not a function
    at parseFilter (RunSection.tsx:50:26)
    at RunSection (RunSection.tsx:62:22)
    ...

The above error occurred in the <RunSection> component.

Copy link
Collaborator Author

When I select a date the app crashes

image.png

TypeError: filter.split is not a function
    at parseFilter (RunSection.tsx:50:26)
    at RunSection (RunSection.tsx:62:22)
    ...

The above error occurred in the <RunSection> component.

​That is correct. I haven't hooked the API up to the client so things break. Later in the stack you will see that it works.

Copy link
Collaborator

Any reason to not make it fail gracefully up until the PR where the functionality is actually implemented?

In theory we ship this stack as one. But there's a chance we don't... I feel a little icky about having a PR with a known crash in it (even if that crash is fixed later in the stack)

@Mbeaulne
Copy link
Collaborator Author

Any reason to not make it fail gracefully up until the PR where the functionality is actually implemented?

In theory we ship this stack as one. But there's a chance we don't... I feel a little icky about having a PR with a known crash in it (even if that crash is fixed later in the stack)

This is all behind a feature flag that explicitly says its UI only. I think its very low risk, and we will likely launch it all at once anyway

@Mbeaulne Mbeaulne dismissed camielvs’s stale review February 18, 2026 14:55

I Don't think we should be too concerned with "broken" UI since its behind a feature flag and will likely get merged into production at the same time as the rest of the stack

Copy link
Collaborator Author

Mbeaulne commented Feb 18, 2026

Merge activity

  • Feb 18, 2:55 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 18, 2:55 PM UTC: Graphite rebased this pull request as part of a merge.
  • Feb 18, 2:57 PM UTC: @Mbeaulne merged this pull request with Graphite.

@Mbeaulne Mbeaulne merged commit 00e3822 into master Feb 18, 2026
8 checks passed
@Mbeaulne Mbeaulne deleted the 01-27-date_picker branch February 18, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments