Skip to content

Conversation

@Owen-Liuyuxuan
Copy link
Contributor

@Owen-Liuyuxuan Owen-Liuyuxuan commented Nov 11, 2024

PR Type

  • New Feature

Related Links

CUDA Adaptation

https://github.com/Owen-Liuyuxuan/autoware_type_adapters

YOLOX Adapatation

tier4/autoware_universe#1637

Description

Using Type Adaptation to allow transferring messages while keeping them in GPU.

Build the PR branch along with autoware_type_adapters in an anvil Orin, we can get things running.

  • Implement type adapters for NPP rectification and Jetson compression.
  • I have tested that it correctly rectified and compressed images on an Anvil with four 20Hz 1920*1080 images.
  • We can use the node interface as if it is still a normal image.
  • But as we also implement YoloX interface/process with type_adapters, we could obtain much more significantly improvements.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Owen-Liuyuxuan and others added 3 commits November 11, 2024 14:57
Signed-off-by: YuxuanLiuTier4Desktop <619684051@qq.com>
Signed-off-by: Yuxuan Liu <uken.ryu.2@tier4.jp>
Signed-off-by: Yuxuan Liu <uken.ryu.2@tier4.jp>
TEST_ERROR(buffer_->allocateMemory() != 0, "NvBuffer allocation failed");

encoder_->setCropRect(0, 0, width, height);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a common bug fix, not directly related to type adaptation, but needed.

Signed-off-by: Yuxuan Liu <619684051@qq.com>
Signed-off-by: YuxuanLiuTier4Desktop <619684051@qq.com>
@Owen-Liuyuxuan Owen-Liuyuxuan mentioned this pull request Jun 2, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants