Skip to content

Update contact lookup sample#559

Merged
gspencergoog merged 1 commit intogoogle:mainfrom
nan-yu:update-contact-lookup-sample
Feb 13, 2026
Merged

Update contact lookup sample#559
gspencergoog merged 1 commit intogoogle:mainfrom
nan-yu:update-contact-lookup-sample

Conversation

@nan-yu
Copy link
Collaborator

@nan-yu nan-yu commented Jan 27, 2026

Tested:

  • The contact_lookup client successfully connected to the contact_lookup agent and rendered the response correctly

Description

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. For larger changes, raising an issue first helps reduce redundant work.

Pre-launch Checklist

If you need help, consider asking for advice on the discussion board.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant and well-structured refactoring to create a centralized a2ui-agent package for managing A2UI schemas. The changes include a build-time hook to package schema files, a robust schema manager with fallback loading mechanisms, and a validator. The contact lookup sample has been updated to use this new package, which greatly improves maintainability and decouples the agent from hardcoded schemas. The overall approach is excellent. I've identified a few critical and high-severity issues related to exception handling and a NameError that could break the code at runtime, along with some medium-severity suggestions to improve the robustness of the build script and validation logic.

@nan-yu nan-yu force-pushed the update-contact-lookup-sample branch 4 times, most recently from 6bc12ec to 6714d4f Compare January 28, 2026 20:52
@nan-yu nan-yu force-pushed the update-contact-lookup-sample branch 3 times, most recently from 557fe78 to 7f8af23 Compare February 11, 2026 23:54
@nan-yu nan-yu force-pushed the update-contact-lookup-sample branch from 7f8af23 to 187797d Compare February 12, 2026 18:02
@nan-yu nan-yu requested a review from zeroasterisk as a code owner February 12, 2026 18:02
@nan-yu nan-yu force-pushed the update-contact-lookup-sample branch from 187797d to 91121f2 Compare February 12, 2026 18:07
@google google deleted a comment from gemini-code-assist bot Feb 12, 2026
Copy link
Collaborator

@zeroasterisk zeroasterisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — clean CI improvements and schema packing hook. 👍

@nan-yu
Copy link
Collaborator Author

nan-yu commented Feb 13, 2026

Rebased and ready for another look.

Tested:
- [x] The contact_lookup client successfully connected to the contact_lookup
agent and rendered the response correctly.
@nan-yu nan-yu force-pushed the update-contact-lookup-sample branch from ec97517 to 36fa487 Compare February 13, 2026 21:03
@gspencergoog gspencergoog merged commit 53b8de4 into google:main Feb 13, 2026
7 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in A2UI Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants