Update restaurant finder sample #570
Open
+4,087
−3,226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new a2ui-agent Python SDK to centralize schema management and updates the existing samples to use it. This is a great architectural improvement that removes hardcoded schemas from the samples and makes them more maintainable. The new A2uiSchemaManager provides a robust way to load, bundle, and validate schemas, with fallbacks for different execution environments. My review focuses on improving the robustness of the new SDK, particularly around exception handling and ensuring functions are side-effect-free.
a2a_agents/python/a2ui_agent/src/a2ui/inference/schema/loader.py
Outdated
Show resolved
Hide resolved
a2a_agents/python/a2ui_agent/src/a2ui/inference/schema/manager.py
Outdated
Show resolved
Hide resolved
a2a_agents/python/a2ui_agent/src/a2ui/inference/schema/common_modifiers.py
Show resolved
Hide resolved
a2a_agents/python/a2ui_agent/src/a2ui/inference/template/manager.py
Outdated
Show resolved
Hide resolved
nan-yu
force-pushed
the
update-restaurant-finder-sample
branch
2 times, most recently
from
5ccd1fd to
4bd12e5
Compare
Collaborator
|
/gemini summary |
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
- Add a base InferenceStrategy class - Add PackSpecsBuildHook to copy JSON schemas into the package during build time. - Update pyproject.toml to include assets and configure the build hook. - Implement A2uiSchemaManager for robust schema loading, pruning, and prompt generation.
Tested: - [x] The contact_lookup client successfully connected to the contact_lookup agent and rendered the response correctly.
Introduces a `schema_modifiers` parameter to A2uiSchemaManager, allowing custom callable hooks to transform schemas after loading. This enables flexible schema customization, such as relaxing strict validation constraints during testing.
It updates the sample to use the A2uiSchemaManager from the a2ui-agent python SDK. Tested: - [x] The `contact` lit client successfully connected to the `contact_multiple_surfaces` agent and rendered the response correctly.
It updates the sample to use the A2uiSchemaManager from the a2ui-agent python SDK. Tested: - [x] The `restaurant` angular client successfully connected to the `restaurant_finder` agent and rendered the response correctly.
nan-yu
force-pushed
the
update-restaurant-finder-sample
branch
from
4bd12e5 to
1fdda40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It updates the sample to use the A2uiSchemaManager from the a2ui-agent python SDK.
Tested:
restaurantangular client successfully connected to therestaurant_finderagent and rendered the response correctly.Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.