Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a significant and valuable refactoring by creating the A2uiSchemaManager to centralize schema loading, management, and prompt generation. This makes the system more robust and easier to extend. The use of build hooks to package schema files and the clear separation of concerns in the new inference package are excellent design choices. However, I've identified a few issues, including a critical one where validation is disabled in one of the samples, which should be addressed before merging.
a2a_agents/python/a2ui_agent/src/a2ui/inference/schema/manager.py
Outdated
Show resolved
Hide resolved
nan-yu
force-pushed
the
update-rizzchart-sample
branch
2 times, most recently
from
f398270 to
6bb60e0
Compare
nan-yu
force-pushed
the
update-rizzchart-sample
branch
from
6bb60e0 to
f350823
Compare
nan-yu
requested review from
ava-cassiopeia,
ditman,
paullewis and
zeroasterisk
as code owners
Collaborator
It updates the sample to use the A2uiSchemaManager from the a2ui-agent python SDK. Tested: - [x] The `rizzcharts` Angular client successfully connected to the `rizzcharts` agent and rendered the response correctly.
nan-yu
force-pushed
the
update-rizzchart-sample
branch
from
f350823 to
9e911d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It updates the sample to use the A2uiSchemaManager from the a2ui-agent python SDK.
Tested:
rizzchartsAngular client successfully connected to therizzchartsagent and rendered the response correctly.rizzcharts_demo.mov
orchestatorAngular client successfully connected to theorchestatoragent and all subagents.orchestrator_demo.mov
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.