Skip to content

fix(PM-3108): send payments only for topgear org and send user_id in the response #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hentrymartin wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(PM-3108): send payments only for topgear org and send user_id in the response #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ workflows:
branches:
only:
- develop
- pm-1127_1
- pm-3108

# Production builds are exectuted only on tagged commits to the
# master branch.
Expand Down
8 changes: 7 additions & 1 deletion sql/reports/topgear/payments.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,15 @@ SELECT
p.total_amount,
p.payment_status,
p.billing_account,
p.created_at
p.created_at,
pr.user_id AS user_id
FROM finance.payment p
INNER JOIN finance.winnings w on p.winnings_id = w.winning_id
LEFT JOIN finance.payment_release_associations pra
ON pra.payment_id = p.payment_id
LEFT JOIN finance.payment_releases pr
ON pr.payment_release_id = pra.payment_release_id
WHERE p.created_at >= $1::timestamptz
AND p.created_at <= $2::timestamptz
AND p.billing_account = '80000062'
Copy link

@github-actions github-actions bot Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ maintainability]
The hardcoded billing account number '80000062' could be extracted into a parameter or configuration to improve maintainability and flexibility. This would make it easier to change the billing account without modifying the code.

ORDER BY p.created_at DESC;
Loading