fix(PM-3108): send payments only for topgear org and send user_id in the response #31
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ON pr.payment_release_id = pra.payment_release_id | ||
| WHERE p.created_at >= $1::timestamptz | ||
| AND p.created_at <= $2::timestamptz | ||
| AND p.billing_account = '80000062' |
There was a problem hiding this comment.
[maintainability]
The hardcoded billing account number '80000062' could be extracted into a parameter or configuration to improve maintainability and flexibility. This would make it easier to change the billing account without modifying the code.
jmgasper
left a comment
jmgasper
left a comment
There was a problem hiding this comment.
Why are we joining into payment_release_associations and payment_releases? Can't we get the user_id from winnings.winner_id?
@kkartunov ☝️
Yes, @hentrymartin user id can get from |
|
Please update your PR. |
|
@kkartunov - I tweaked this update and sent it to prod, so all good. Wanted to get it done before I was out for a couple of days. |
What's in this PR?
Ticket link - https://topcoder.atlassian.net/browse/PM-3108