Skip to content

fix: handle NumberFormatException in ClassifiedListingEventDeserializer #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

fix: handle NumberFormatException in ClassifiedListingEventDeserializer #504

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da1e089
Initial plan
Copilot Jan 21, 2026
172bc0b
fix: handle NumberFormatException in ClassifiedListingEventDeserializer
Copilot Jan 21, 2026
392bc53
refactor: improve error message specificity in ClassifiedListingEvent…
Copilot Jan 21, 2026
95f0d51
fix: add null checks for required fields in ClassifiedListingEventDes…
Copilot Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 32 additions & 11 deletions ...event/src/main/java/nostr/event/json/deserializer/ClassifiedListingEventDeserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,37 @@ public ClassifiedListingEvent deserialize(JsonParser jsonParser, Deserialization
generalMap.put(key, classifiedListingEventNode.get(key).asText());
}

ClassifiedListingEvent classifiedListingEvent =
new ClassifiedListingEvent(
new PublicKey(generalMap.get("pubkey")),
Kind.valueOfStrict(Integer.parseInt(generalMap.get("kind"))),
baseTags,
generalMap.get("content"));
classifiedListingEvent.setId(generalMap.get("id"));
classifiedListingEvent.setCreatedAt(Long.valueOf(generalMap.get("created_at")));
classifiedListingEvent.setSignature(Signature.fromString(generalMap.get("sig")));

return classifiedListingEvent;
String kindValue = generalMap.get("kind");
String createdAtValue = generalMap.get("created_at");

try {
if (kindValue == null) {
throw new IOException("Missing required field 'kind' in ClassifiedListingEvent");
}
if (createdAtValue == null) {
throw new IOException("Missing required field 'created_at' in ClassifiedListingEvent");
}

int kindInt = Integer.parseInt(kindValue);
long createdAt = Long.parseLong(createdAtValue);

ClassifiedListingEvent classifiedListingEvent =
new ClassifiedListingEvent(
new PublicKey(generalMap.get("pubkey")),
Kind.valueOfStrict(kindInt),
baseTags,
generalMap.get("content"));
classifiedListingEvent.setId(generalMap.get("id"));
classifiedListingEvent.setCreatedAt(createdAt);
classifiedListingEvent.setSignature(Signature.fromString(generalMap.get("sig")));

return classifiedListingEvent;
} catch (NumberFormatException ex) {
throw new IOException(
String.format(
"Failed to parse numeric field in ClassifiedListingEvent - kind='%s', created_at='%s': %s",
kindValue, createdAtValue, ex.getMessage()),
ex);
}
}
}