fix: handle NumberFormatException in ClassifiedListingEventDeserializer #504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ClassifiedListingEventDeserializerhad unguardedInteger.parseInt()andLong.parseLong()calls that could throw uncaught exceptions on malformed JSON input.Type of change
fix- Bug fix (non-breaking)What changed?
Added fail-fast validation and exception handling:
Changes:
NumberFormatException→IOExceptionwith field contextBreaking changes
None.
Testing
mvn testmvn verify(requires Docker)Review focus
Error message format provides sufficient context for debugging malformed events?
Checklist
type(scope): description💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.