improve i18n and correct url in Special:Version#80
Open
dennisroczek wants to merge 7 commits intomozilla:mainfrom
Open
improve i18n and correct url in Special:Version#80dennisroczek wants to merge 7 commits intomozilla:mainfrom
dennisroczek wants to merge 7 commits intomozilla:mainfrom
Conversation
…thus raising bar to mediawiki ~1.23)
deprecated since 1.23, see https://www.mediawiki.org/wiki/Manual:$wgExtensionMessagesFiles
Contributor
|
Cool, looks like Mozilla upgraded a while ago: |
Contributor
|
Can you add the version requirement to the README? |
Contributor
Author
|
will do. I do also started to move i18n stuff from e.g. web/js/jquery.dataTables.js to the json files and get the user language of the logged in user (so not only English UI, but when translated the language of the logged in user!) |
Contributor
|
🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removing deprecated I18N calls and thus raising requirements to MediaWiki 1.23+.
There is also a possibility to include a wrapper for backward compatibility back to MediaWiki 1.17, see for example https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FNews/926d59e7ba619d1975b063172c68a191dde88fe9/News.i18n.php