Skip to content

Conversation

@rdalverny
Copy link
Contributor

This removes all BugzillaCache* classes and code that used it, replaces it with MediaWiki wfGetCache($wgMainCacheType), which provides sensibly the same set of options.

Doing so simplifies a first install, by removing specific configuration for this extension; and reduces the code base.

@LegNeato
Copy link
Contributor

Again, sorry for the delay! Does this affect the min version of mediawiki supported? We'll also need someone from mozilla to confirm that they use wfGetCache and their installation will continue to work.

This removes all BugzillaCache* classes and code that used it,
replaces it with MediaWiki `wfGetCache($wgMainCacheType)`,
which provides sensibly the same set of options.

Doing so also simplifies a first install, by removing specific
configuration for this extension.
@rdalverny
Copy link
Contributor Author

Again, sorry for the delay!

No worries!

Does this affect the min version of mediawiki supported?

wfGetCache has been last refactored in wikimedia/mediawiki@be76d86 in March 2011. So any MW 1.16+ is fine. What is the current min version supported at this point?

We'll also need someone from mozilla to confirm that they use wfGetCache and their installation will continue to work.

Yes! Maybe I can add a section in the README about this (configuring $wgMainCacheType).

@LegNeato
Copy link
Contributor

LegNeato commented Jan 4, 2017

I'm not sure who to ping for mozwiki...most of the bugs look like they haven't been touched in a bit. @christi3k? Or do you have any pointers to someone else? Thanks!

@dennisroczek
Copy link
Contributor

well for the case I will have time to finish my pull request then the min MW1.23+ requirement would be
#80

Moreover we finally could use JQuerry from MediaWiki itself (see #26) :-)

@hexmode
Copy link
Contributor

hexmode commented Jan 4, 2017

I don't think @christi3k is going to be available to help. I think I have the right to merge pull requests.

MozWiki should be updated to the latest LTS since 1.23 is being EOL'd in May. See https://www.mediawiki.org/wiki/Version_lifecycle#Versions_and_their_end-of-life

@LegNeato LegNeato merged commit c53fe08 into mozilla:master May 11, 2017
@LegNeato
Copy link
Contributor

Lets get this one in, sorry for the delay!

@rdalverny
Copy link
Contributor Author

Thank you! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants