Skip to content

MLE-27077 Disabling ARM tests #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjrudin merged 1 commit into from
Feb 11, 2026
Merged

MLE-27077 Disabling ARM tests #1900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def getPlatform(isArm = false) {
return isArm ? "linux/arm64" : "linux/amd64"
}

def setConverters(isArm = false) {
def shouldInstallConverters(isArm = false) {
return isArm ? "false" :"true"
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldInstallConverters reads like it returns a boolean, but it returns string literals (\"true\"/\"false\"). Either return actual booleans (and let Jenkins handle coercion where needed) or rename the function to make it clear it returns an env-var string value (e.g., getInstallConvertersEnvValue).

Suggested change
return isArm ? "false" :"true"
return !isArm

Copilot uses AI. Check for mistakes.
}

Expand Down Expand Up @@ -198,7 +198,7 @@ pipeline {
DMC_USER = credentials('MLBUILD_USER')
DMC_PASSWORD = credentials('MLBUILD_PASSWORD')
PLATFORM = getPlatform()
MARKLOGIC_INSTALL_CONVERTERS = setConverters()
MARKLOGIC_INSTALL_CONVERTERS = shouldInstallConverters()
}

stages {
Expand Down Expand Up @@ -293,7 +293,7 @@ pipeline {

stage('provisionInfrastructure'){
when {
branch 'develop'
branch 'develop-arm'
expression { return !params.regressions }
Comment on lines +296 to 297
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a different branch name to effectively disable the stage is a non-obvious control mechanism and can be confusing for future maintainers (and it will still run if someone builds develop-arm). Consider making the disablement explicit (e.g., a dedicated parameter/flag, or a when { expression { false } } with a TODO referencing MLE-27077) so the intent is clear in the Jenkinsfile itself.

Suggested change
branch 'develop-arm'
expression { return !params.regressions }
// TODO(MLE-27077): Stage intentionally disabled; update this condition when ready to re-enable.
expression { return false }

Copilot uses AI. Check for mistakes.
}
agent {label 'javaClientLinuxPool'}
Expand Down Expand Up @@ -376,15 +376,15 @@ pipeline {
stage('regressions-11 arm infrastructure') {
when {
beforeAgent true
branch 'develop'
branch 'develop-arm'
expression { return !params.regressions }
expression { return env.EC2_PRIVATE_IP != null }
}
agent { label "java-client-agent-${BUILD_NUMBER}" }
environment {
JAVA_HOME_DIR = getJavaHomePath(true)
PLATFORM = getPlatform(true)
MARKLOGIC_INSTALL_CONVERTERS = setConverters(true)
MARKLOGIC_INSTALL_CONVERTERS = shouldInstallConverters(true)
}
steps {
checkout([$class: 'GitSCM',
Expand Down