-
Notifications
You must be signed in to change notification settings - Fork 74
MLE-27077 Disabling ARM tests #1900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These are running on a non-regression build, which we don't want. Modified the branch so they don't run at all for now.
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ All files have valid copyright headers! |
|
Merging right away to unblock the publish pipeline for the Java Client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Disables ARM-related pipeline stages for non-regression builds by changing branch gating and renames the helper used to compute the “install converters” flag.
Changes:
- Renamed
setConvertershelper toshouldInstallConvertersand updated call sites. - Changed
when { branch 'develop' }towhen { branch 'develop-arm' }for ARM infra-related stages to prevent running ondevelop.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| def setConverters(isArm = false) { | ||
| def shouldInstallConverters(isArm = false) { | ||
| return isArm ? "false" :"true" |
Copilot
AI
Feb 11, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldInstallConverters reads like it returns a boolean, but it returns string literals (\"true\"/\"false\"). Either return actual booleans (and let Jenkins handle coercion where needed) or rename the function to make it clear it returns an env-var string value (e.g., getInstallConvertersEnvValue).
| return isArm ? "false" :"true" | |
| return !isArm |
| branch 'develop-arm' | ||
| expression { return !params.regressions } |
Copilot
AI
Feb 11, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a different branch name to effectively disable the stage is a non-obvious control mechanism and can be confusing for future maintainers (and it will still run if someone builds develop-arm). Consider making the disablement explicit (e.g., a dedicated parameter/flag, or a when { expression { false } } with a TODO referencing MLE-27077) so the intent is clear in the Jenkinsfile itself.
| branch 'develop-arm' | |
| expression { return !params.regressions } | |
| // TODO(MLE-27077): Stage intentionally disabled; update this condition when ready to re-enable. | |
| expression { return false } |
These are running on a non-regression build, which we don't want. Modified the branch so they don't run at all for now.