Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Feb 11, 2026

These are running on a non-regression build, which we don't want. Modified the branch so they don't run at all for now.

These are running on a non-regression build, which we don't want. Modified the branch so they don't run at all for now.
Copilot AI review requested due to automatic review settings February 11, 2026 14:15
@github-actions
Copy link

Copyright Validation Results
Total: 1 | Passed: 0 | Failed: 0 | Skipped: 1 | at: 2026-02-11 14:16:09 UTC | commit: f10d037

⏭️ Skipped (Excluded) Files

  • Jenkinsfile

✅ All files have valid copyright headers!

@rjrudin
Copy link
Contributor Author

rjrudin commented Feb 11, 2026

Merging right away to unblock the publish pipeline for the Java Client

@rjrudin rjrudin merged commit e4bd082 into develop Feb 11, 2026
3 of 4 checks passed
@rjrudin rjrudin deleted the feature/jenkins-fix branch February 11, 2026 14:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables ARM-related pipeline stages for non-regression builds by changing branch gating and renames the helper used to compute the “install converters” flag.

Changes:

  • Renamed setConverters helper to shouldInstallConverters and updated call sites.
  • Changed when { branch 'develop' } to when { branch 'develop-arm' } for ARM infra-related stages to prevent running on develop.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


def setConverters(isArm = false) {
def shouldInstallConverters(isArm = false) {
return isArm ? "false" :"true"
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldInstallConverters reads like it returns a boolean, but it returns string literals (\"true\"/\"false\"). Either return actual booleans (and let Jenkins handle coercion where needed) or rename the function to make it clear it returns an env-var string value (e.g., getInstallConvertersEnvValue).

Suggested change
return isArm ? "false" :"true"
return !isArm

Copilot uses AI. Check for mistakes.
Comment on lines +296 to 297
branch 'develop-arm'
expression { return !params.regressions }
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a different branch name to effectively disable the stage is a non-obvious control mechanism and can be confusing for future maintainers (and it will still run if someone builds develop-arm). Consider making the disablement explicit (e.g., a dedicated parameter/flag, or a when { expression { false } } with a TODO referencing MLE-27077) so the intent is clear in the Jenkinsfile itself.

Suggested change
branch 'develop-arm'
expression { return !params.regressions }
// TODO(MLE-27077): Stage intentionally disabled; update this condition when ready to re-enable.
expression { return false }

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant