main.py: cards: get right version from abs_url#271
Closed
adriendupuis wants to merge 5 commits intomasterfrom
Closed
main.py: cards: get right version from abs_url#271adriendupuis wants to merge 5 commits intomasterfrom
adriendupuis wants to merge 5 commits intomasterfrom
Conversation
adriendupuis
commented
Feb 23, 2024
|
adriendupuis
commented
Feb 23, 2024
main.py
Outdated
Comment on lines
49
to
50
| url_parts = re.search("//([^/]+)/([^/]+)/([^/]+)/([^/]+)/([^/]+)/", canonical) | ||
| (site, project, edition, language, version) = url_parts.groups() |
Contributor
Author
There was a problem hiding this comment.
site is not really useful. Those two lines should be removed, and site removed below from the rebuilt URLs passed to the cards.
|
5 tasks
Contributor
Author
|
See #288 |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug example:
https://doc.ibexa.co/projects/userguide/en/4.5/persona_paths/author_content/ "Edit image"
In persona_paths/author_content.md, content_management/edit_images/ refers to 4.5 file which doesn't exist on master or 4.6 (moved to image_management/edit_images/).
Bug origin: The
canonical_urlis always onlatest(4.6) socardsmay compute a wrong cross-version URL (404).Bug fix: usedoesn't work: onabs_urlto get the right version.4.5prod,versionstill equalslatest.Checklist