main.py cards: get version from abs URL#2541
Closed
adriendupuis wants to merge 1 commit intomasterfrom
Closed
Conversation
The canonical URL seems to always be the "latest" version. So, previously, version was always "latest" even when on another version (like "master" for example), potentially generating a broken link.
Contributor
Author
|
Wrong track In ibexa/documentation-user#271, I already noticed that current version can't be obtained this way. See ibexa/documentation-user#288 for other tries to fix this. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating card link, get the current version from the absolute URL instead of the canonical URL.
The canonical URL seems to always be the "latest" version. So, previously, version was always "latest" even when on another version (like "master" for example), potentially generating a broken link.
For example,
https://doc.ibexa.co/en/master/users/users/ “Update basic user data from CLI” card is a broken link because the target page doesn't exists on latest, only on master.
Checklist