Add Go 1.8 TLS tracing support & refactor timing code#128
Open
rs wants to merge 1 commit intodavecheney:masterfrom
Open
Add Go 1.8 TLS tracing support & refactor timing code#128rs wants to merge 1 commit intodavecheney:masterfrom
rs wants to merge 1 commit intodavecheney:masterfrom
Conversation
Author
|
@davecheney: The failing test does also fail on master. |
Author
|
@davecheney some tests are still failing, even after the fix. Apparently, httpbin has some connectivity issue. Please just relaunch the test. |
davecheney
reviewed
Apr 28, 2018
.travis.yml
Outdated
| - 1.9.x | ||
| - "1.8.x" | ||
| - "1.9.x" | ||
| - "1.10.x" |
Owner
There was a problem hiding this comment.
Please change this to
- 1.10.x
exactly.
Author
|
Done, tests are still randomly failing though. |
Owner
|
I've merged a few of the outstanding commits, can you please rebase and we'll see what's left. |
Owner
|
I think i've fixed the failing tests, please try again. |
To have accurate measurement of TLS and support skipped steps (DNS, TCP and TLS reuse), the timing code has been refactored to use Go 1.8 support for TLS tracing as well as a more descriptive variable namings for steps time. This commit removes support for Go versions lower than 1.8.
Author
|
httpbin is still failing from travis. |
Author
|
@davecheney what about removing the httpbin tests? Could be replaced by a mock server. |
Author
|
@davecheney any chance to merge this? |
|
@davecheney any chance to have a look at this? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To have accurate measurement of TLS and support skipped steps (DNS, TCP
and TLS reuse), the timing code has been refactored to use Go 1.8
support for TLS tracing as well as a more descriptive variable namings
for steps time.
This commit removes support for Go versions lower than 1.8.