Open
Conversation
To have accurate measurement of TLS and support skipped steps (DNS, TCP and TLS reuse), the timing code has been refactored to use Go 1.8 support for TLS tracing as well as a more descriptive variable namings for steps time. This commit removes support for Go versions lower than 1.8.
Example output (whitespace and carriage returns added for readibility):
{
"Address": "128.199.248.140:443",
"Header": {
"Connection": [
"keep-alive"
],
"Content-Type": [
"text/html; charset=UTF-8"
],
"Date": [
"Sat, 05 May 2018 03:15:15 GMT"
],
"Link": [
"<https://dave.cheney.net/wp-json/>; rel=\"https://api.w.org/\""
],
"Server": [
"nginx/1.2.1"
],
"Strict-Transport-Security": [
"max-age=15768000"
],
"X-Powered-By": [
"PHP/5.4.45-0+deb7u11"
]
},
"Proto": "HTTP/1.1",
"Status": "200 OK",
"Timing": {
"DNS": 98,
"TCP": 191,
"TLS": 604,
"Server": 747,
"Transfer": 392,
"Lookup": 98,
"Connect": 290,
"PreTransfer": 895,
"StartTransfer": 1643,
"Total": 2036
}
}
Author
|
This PR is based on #128 |
Owner
|
This PR is dirty, please rebase it onto master.
Each PR should close an issue, with a Fixes #nnnn
… On 5 May 2018, at 13:22, Olivier Poitrey ***@***.***> wrote:
This PR is based on #128
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Author
|
As explained in the previous comment, this PR is based on #128. I'm waiting for it to be merged before rebasing on master. I sent this PR to share a feature I added for my own use. There is no issue associated, it fixes nothing. I can open a separate issue if it's the way you want it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example output (whitespace and carriage returns added for readibility):