start: Only map volumes if required on macOS #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kholisrag
approved these changes
Jun 9, 2025
Collaborator
|
Thanks for the PR! We should start using |
slp
requested changes
Jun 12, 2025
Collaborator
slp
left a comment
slp
left a comment
There was a problem hiding this comment.
Could you please sign the commit (Signed-off-by) to fix the DCO test?
In issue #67, it was reported that VM creation on macOS always fails with the message: "Error setting VM mapped volumes". [^1] It appears krun always calls `krun_set_mapped_volumes` even if the user has not configured any volumes. That krun library function was disabled in Feb 2024 by commit 186083df9. [^2] Based on the commit message, it sounds like virtio-fs devices will be the preferred way to implement mapped volumes going forward. For now, we can at least avoid calling the deprecated function if the user has not configured any mapped volumes. That will obviously not fix the krun feature, but it makes krunvm usable on macOS. References 1. #67 2. libkrun commit 186083df9faf704e2b431d90b1ed147363aca004 Signed-off-by: Stephen Fox <stephen.j.fox.jr@gmail.com>
stephen-fox
force-pushed
the
macos-only-map-volumes-if-required
branch
from
857f718 to
28ad60f
Compare
Contributor
Author
|
@slp, I updated the commit with the "Signed-off-by" string. |
Grego-GT
added a commit
to BinSquare/ERA
that referenced
this pull request
Nov 2, 2025
…--> Workaround by using scripts for uploading and downloading files to/from ERA local VMs. These scripts implement file transfer utilities that encode files to base64, transfer chunks via VM command execution, and reconstruct files on the destination side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #67, it was reported that VM creation on macOS always fails with the message: "Error setting VM mapped volumes". [^1] It appears krun always calls
krun_set_mapped_volumeseven if the user has not configured any volumes. That krun library function was disabled in Feb 2024 by commit 186083df9. [^2] Based on the commit message, it sounds like virtio-fs devices will be the preferred way to implement mapped volumes going forward.For now, we can at least avoid calling the deprecated function if the user has not configured any mapped volumes. That will obviously not fix the krun feature, but it makes krunvm usable on macOS.
References