Fixing mapped volumes on MacOS by replacing deprecated method with krun_add_virtiofs. #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This one looks great, thanks! Please fix it the formatting issues and I'll merge it and cut a new release. |
Signed-off-by: BinBin He <hebinsquared@gmail.com>
Signed-off-by: BinBin He <hebinsquared@gmail.com>
Signed-off-by: BinBin He <hebinsquared@gmail.com>
Author
Wonderful, passing cargo fmt now PTAL! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt to fix this issue: #67
Implemented krun_add_virtiofs from libkrun per @slp's comment: #68 (comment).
Additionally, I noticed libkrun had krun_add_virtiofs2 but I can't reason about what that shm_size results in as an end user (please enlighten me if anyone knows).
Testing: