-
Notifications
You must be signed in to change notification settings - Fork 314
Make wasm-wave support no_std
#2401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Make wasm-wave support no_std
#2401
Conversation
|
Oh, also, mind adding checks to CI that this builds with various combinations of features? We do similar for other crates in |
f8548fd to
4f64af9
Compare
|
Addressing the remaining CI failures: One of the jobs is failing on:
The other job is failing on the successfully locally so I am unable to reproduce this. |
|
Ok #2402 should address the CI issues here. Once that is merged if you can rebase on top of that I think that'll have everything "just work" |
|
|
||
| fn finish_flags(&mut self, start: usize) -> Result<Node, ParserError> { | ||
| let mut flags = IndexMap::with_capacity(1); | ||
| let mut flags = BTreeMap::new(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a (small) functional change, switching the ordering of serialized flags from definition-ordered to lexicographical. I don't see this behavior documented anywhere so its probably fine. Clearly it wasn't important enough to me to assert it in a test case. 😅
remove main.yml formatting change add back newline
dda8709 to
acecb6b
Compare
String,Vec, etc. fromcoreandallocinstead ofstd.indexmapdep in favor ofalloc::collections::BTreeMapstd::collections::HashMapis replaced withalloc::collections::BTreeMapuitest is conditioned onwitfeaturestdfeature and included it indefaultlistCrate tests pass for me locally for both:
and
#2399