-
Notifications
You must be signed in to change notification settings - Fork 314
Description
In a project I'm working on we are using wasm_wave within modules. Ideally we can make these modules compile with no_std but the wasm_wave dep is currently preventing that. For my use-case I am disabling the default wit feature which adds the wit-parser dependency so that crate would not need to become no_std.
Very similar situation to this issues: #3
I'm happy to do this work and can follow the patterns in this PR: #1493
But I want to check with the maintainers first that this is an acceptable change and if they have opinions on how it should be done i.e.
Should a non-default no_std feature or a default std feature that can be disabled be created? Or maybe an alloc feature instead?
What Map object should be used instead of std::collections::HashMap? I noticed that indexmap is a dep but it has the std feature enabled.