Skip to content

Block: Correctly load viewStyle in the head tag when wp_should_load_block_assets_on_demand is false#9249

Closed
t-hamano wants to merge 1 commit intoWordPress:trunkfrom
t-hamano:63695/view-style-load-head
Closed

Block: Correctly load viewStyle in the head tag when wp_should_load_block_assets_on_demand is false#9249
t-hamano wants to merge 1 commit intoWordPress:trunkfrom
t-hamano:63695/view-style-load-head

Conversation

@t-hamano
Copy link
Contributor

Trac ticket: https://core.trac.wordpress.org/ticket/63695


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Jul 12, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @Kaycee2815.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props wildworks.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano changed the title Block: Load viewStyle in the head tag when wp_should_load_block_assets_on_demand is false Block: Loads viewStyles consistently in the head tag when wp_should_load_block_assets_on_demand is false Jul 12, 2025
@t-hamano t-hamano force-pushed the 63695/view-style-load-head branch from be6233e to 584d517 Compare July 12, 2025 04:27
@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@t-hamano t-hamano force-pushed the 63695/view-style-load-head branch from 584d517 to e360e72 Compare July 12, 2025 05:43
@t-hamano t-hamano changed the title Block: Loads viewStyles consistently in the head tag when wp_should_load_block_assets_on_demand is false Block: Correctly load viewStyle in the head tag when wp_should_load_block_assets_on_demand is false Jul 12, 2025
@Kaycee2815
Copy link

Thanks

@t-hamano
Copy link
Contributor Author

Oh, I re-forked the wordpress-develop repo and it seems all my submitted open PRs were closed 😂 I submitted a new PR that is equivalent to this one. #10925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants