Block: Correctly load viewStyle in the head tag when wp_should_load_block_assets_on_demand is false#10925
Block: Correctly load viewStyle in the head tag when wp_should_load_block_assets_on_demand is false#10925t-hamano wants to merge 1 commit intoWordPress:trunkfrom
Conversation
…lock_assets_on_demand is false
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| } elseif ( ! is_admin() ) { | ||
| // Front-end styles. | ||
| foreach ( $block_type->view_style_handles as $view_style_handle ) { | ||
| wp_enqueue_style( $view_style_handle ); |
There was a problem hiding this comment.
So if block styles aren't loaded on demand, this will load every single style for every single registered block on the frontend? This had been the default experience for classic themes, and prior to 6.9, this could mean a lot more styles get enqueued. But with Core-64099, classic themes now enqueue block styles on demand by default. That is, unless you have opted out via a plugin like Load Combined Core Block Assets.
2 participants
Note
This PR is the same as #9249. I submitted this new PR because I accidentally closed #9249 and it can no longer be reopened.
Trac ticket: https://core.trac.wordpress.org/ticket/63695
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.