Fix: Color schema is not correctly applied to the beta label#3938
Fix: Color schema is not correctly applied to the beta label#3938t-hamano wants to merge 3 commits intoWordPress:trunkfrom
Conversation
|
I have confirmed that the "beta" label has been removed. https://core.trac.wordpress.org/changeset/55281 I would like to close this issue as it no longer occurs. |
|
Reopened based on this comment. |
e46859b to
f062c05
Compare
|
Update: Based on the results of this test of the core ticket, I have adjusted the badge colors to be the intended badge colors in various cases. The selector is fairly simple, but simply overrides the default following style. wordpress-develop/src/wp-admin/css/admin-menu.css Lines 449 to 453 in a44e46b With this change, I have removed the I also found a behavior where the background color changes when mousing over an inactive top-level menu if it is not the default theme. However, in this PR, I did not make any changes to the above behavior but focused on the correct badges to be displayed. Default Color SchemeIt should be no different than before. default.mp4Extplasm Color Schemeectoplasm.mp4Ocean Color Schemeocean.mp4 |
|
Oh, I re-forked the |
Trac ticket: https://core.trac.wordpress.org/ticket/57577
The site editor has a beta label and the
.awaiting-modclass is used to indicate that it is a badge. I think this is the class originally used for the comment badge.The background color style for this class works correctly if the top menu is given a badge. However, with the advent of the site editor, I believe the use of this badge in the child menu causes unintended behavior.
Therefore, I have updated the selector so that no matter which menu the badge with this class is used in, the background color will be applied correctly. Ideally, we might need a selector for the site editor, but since the beta label should be removed in the future, I have kept the current class name.
Before
before.mp4
After
after.mp4