Fix: Color schema is not correctly applied to the beta label#10924
Open
t-hamano wants to merge 1 commit intoWordPress:trunkfrom
Open
Fix: Color schema is not correctly applied to the beta label#10924t-hamano wants to merge 1 commit intoWordPress:trunkfrom
t-hamano wants to merge 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR is the same as #3938. I submitted this new PR because I accidentally closed #3938 and it can no longer be reopened.
Trac ticket: https://core.trac.wordpress.org/ticket/57577
The site editor has a beta label and the
.awaiting-modclass is used to indicate that it is a badge. I think this is the class originally used for the comment badge.The background color style for this class works correctly if the top menu is given a badge. However, with the advent of the site editor, I believe the use of this badge in the child menu causes unintended behavior.
Therefore, I have updated the selector so that no matter which menu the badge with this class is used in, the background color will be applied correctly. Ideally, we might need a selector for the site editor, but since the beta label should be removed in the future, I have kept the current class name.
Before
before.mp4
After
after.mp4