get_block_wrapper_attributes: Ensures that user-provided attributes override the attributes generated by block supports#10922
Conversation
…verride the attributes generated by block supports
Co-authored-by: Weston Ruter <westonruter@gmail.com>
Co-authored-by: Weston Ruter <westonruter@gmail.com>
Co-authored-by: Weston Ruter <westonruter@gmail.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| $attributes_to_merge = array( 'style', 'class', 'id', 'aria-label' ); | ||
| $attributes = array(); | ||
| foreach ( $attributes_to_merge as $attribute_name ) { | ||
| $handled_attributes = array( |
There was a problem hiding this comment.
I know I suggested $handled_attributes originally, but now that I look at it it seems confusing because a false would seem to indicate that the attribute is not handled. So what about renaming $handled_attributes as $merged_attributes?
|
|
||
| $attributes[ $attribute_name ] = $extra_attributes[ $attribute_name ] . ' ' . $new_attributes[ $attribute_name ]; | ||
| if ( $is_merged ) { | ||
| $attributes[ $attribute_name ] = $extra_attributes[ $attribute_name ] . ' ' . $new_attributes[ $attribute_name ]; |
There was a problem hiding this comment.
For posterity, #10877 (comment):
In the case of merging
style, should special handling be added to ensure that$extra_attributes[ $attribute_name ]ends in a semicolon? The current empty space is only really appropriate forclass.
Note
This PR is the same as #10877. I submitted this new PR because I accidentally closed #10877 and it can no longer be reopened.
Trac ticket: https://core.trac.wordpress.org/ticket/64603
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.