get_block_wrapper_attributes: Ensures that user-provided attributes override the attributes generated by block supports#10877
Conversation
…verride the attributes generated by block supports
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Co-authored-by: Weston Ruter <westonruter@gmail.com>
Co-authored-by: Weston Ruter <westonruter@gmail.com>
Co-authored-by: Weston Ruter <westonruter@gmail.com>
| continue; | ||
| } | ||
|
|
||
| $attributes[ $attribute_name ] = $extra_attributes[ $attribute_name ] . ' ' . $new_attributes[ $attribute_name ]; |
There was a problem hiding this comment.
In the case of merging style, should special handling be added to ensure that $extra_attributes[ $attribute_name ] ends in a semicolon? The current empty space is only really appropriate for class.
There was a problem hiding this comment.
Perhaps the entire way this function works needs to be completely rethought.
- What happens if a non-array is passed as a parameter?
- What if the array value is not a string?
- What if there is already a semicolon at the end of the style?
However, I'm not sure if all of these fixes should be included in the 7.0 release. The original scope of this PR was to fix the unintended merging of ID attributes. WordPress/gutenberg#75251 (comment)
There was a problem hiding this comment.
Yeah. I guess if there isn't a problem right now then it doesn't have to be fixed. The hardening you identified would be a nice-to-have.
|
Oh, I re-forked the |
Trac ticket: https://core.trac.wordpress.org/ticket/64603
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.