Skip to content

feat(script): remove cdn option #5667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmfrancois wants to merge 12 commits into
base: master
Choose a base branch
from
Open

feat(script): remove cdn option #5667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a1ab028
feat(script): remove cdn option
jmfrancois Dec 23, 2025
da624fc
fix: remove pre-release to build UMD
jmfrancois Dec 23, 2025
5087e97
fix: playground
jmfrancois Dec 23, 2025
0c3235a
test: update
jmfrancois Dec 23, 2025
2f1a148
fix(forms): Code
jmfrancois Dec 23, 2025
a06191f
fix: add missing build:lib:esm
jmfrancois Dec 23, 2025
fdbb039
Merge branch 'master' into jmfrancois/feat/remove-cdn-option
jmfrancois Dec 23, 2025
7a38bbb
fix: test:demo
jmfrancois Dec 24, 2025
27cb062
Create nice-ladybugs-carry.md
jmfrancois Jan 7, 2026
849d8c6
chore: add changeset
jmfrancois Jan 7, 2026
da0aeae
Update nice-ladybugs-carry.md
jmfrancois Jan 7, 2026
97e0a97
test: update
jmfrancois Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/nice-ladybugs-carry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
"@talend/scripts-config-react-webpack": major
---

feat(script): remove cdn option.

You must review your build process with that new plugin as many things will not work.
Especially the @talend/assets-api call you may end up with weird behavior.

The good part is once you have fixed it moving out from @talend/scripts* to an other build tool like vite becomes easy.
30 changes: 30 additions & 0 deletions .changeset/tired-donkeys-add.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
---
'@talend/react-faceted-search-query-client': major
'@talend/scripts-config-react-webpack': major
'@talend/scripts-config-storybook-lib': major
'@talend/json-schema-form-core': major
'@talend/react-faceted-search': major
'@talend/storybook-docs': major
'@talend/design-system': major
'@talend/design-tokens': major
'@talend/react-flow-designer': major
'@talend/router-bridge': major
'@talend/ui-storybook-one': major
'@talend/react-bootstrap': major
'@talend/design-docs': major
'@talend/assets-api': major
'@talend/react-cmf-router': major
'@talend/react-components': major
'@talend/react-containers': major
'@talend/ui-playground': major
'@talend/react-cmf-cqrs': major
'@talend/react-dataviz': major
'@talend/react-stepper': major
'@talend/react-forms': major
'@talend/react-sagas': major
'@talend/bootstrap-theme': major
'@talend/http': major
'@talend/react-cmf': major
---

chore: drop UMD format
4 changes: 2 additions & 2 deletions fork/json-schema-form-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@
"exports": {
".": {
"import": "./lib-esm/index.js",
"require": "./dist/index.js"
"require": "./lib/index.js"
}
},
"scripts": {
"build:lib": "rimraf dist && talend-scripts build --umd",
"build:lib": "talend-scripts build",
"build:lib:esm": "talend-scripts build --esm",
"watch": "webpack --watch",
"dist-untested": "webpack --config webpack.config.dist.js",
Expand Down
3 changes: 0 additions & 3 deletions fork/react-bootstrap/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,7 @@
}
},
"scripts": {
"build:dev": "talend-scripts build --umd --dev",
"build:prod": "talend-scripts build --umd --prod",
"build:lib:esm": "talend-scripts build --esm",
"pre-release": "yarn build:dev && yarn build:prod",
"build:lib": "talend-scripts build",
"lint": "talend-scripts lint",
"test": "talend-scripts test",
Expand Down
1 change: 0 additions & 1 deletion packages/assets-api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
},
"license": "Apache-2.0",
"scripts": {
"pre-release": "talend-scripts build --umd && talend-scripts build --umd --dev",
"build:lib": "talend-scripts build",
"build:lib:esm": "talend-scripts build --esm",
"start": "echo nothing to start",
Expand Down
4 changes: 2 additions & 2 deletions packages/assets-api/src/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ describe('assets-api', () => {
jest.restoreAllMocks();
});

it('should return unpkg url', () => {
it('should return static url', () => {
const url = assetsApi.getURL(bundlePath, '@talend/icons', '6.60.1');
expect(url).toBe(`https://unpkg.com/@talend/icons@6.60.1${bundlePath}`);
expect(url).toBe(`https://statics.cloud.talend.com/@talend/icons/6.60.1${bundlePath}`);
});

it('should return /cdn url', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/assets-api/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ if (!window.Talend.getCDNUrl) {
}
return `${CDN_URL}/${info.name}/${info.version}${info.path}`;
}
return `https://unpkg.com/${info.name}@${info.version}${info.path}`;
return `https://statics.cloud.talend.com/${info.name}/${info.version}${info.path}`;
Copy link
Contributor

@smouillour smouillour Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

};
}

Expand Down
14 changes: 11 additions & 3 deletions packages/cmf-cqrs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,19 @@
"main": "lib/index.js",
"mainSrc": "src/index.ts",
"types": "lib/index.d.ts",
"exports": {
".": {
"import": "./lib-esm/index.js",
"require": "./lib/index.js"
},
"./lib/*": {
"import": "./lib-esm/*",
"require": "./lib/*"
}
},
"scripts": {
"build:dev": "talend-scripts build --umd --dev",
"build:prod": "talend-scripts build --umd --prod",
"pre-release": "yarn build:dev && yarn build:prod",
"build:lib": "talend-scripts build",
Copy link
Contributor

@smouillour smouillour Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an esm version?

"build:lib:esm": "talend-scripts build --esm",
"start": "echo nothing to start",
"test": "talend-scripts test",
"test:watch": "talend-scripts test --watch",
Expand Down
3 changes: 0 additions & 3 deletions packages/cmf-router/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,7 @@
"author": "Talend Frontend <frontend@talend.com> (http://www.talend.com)",
"license": "Apache-2.0",
"scripts": {
"build:dev": "talend-scripts build --umd --dev",
"build:prod": "talend-scripts build --umd --prod",
"build:lib:esm": "talend-scripts build --esm",
"pre-release": "yarn build:dev && yarn build:prod",
"build:lib": "talend-scripts build",
"start": "echo nothing to start",
"test": "talend-scripts test",
Expand Down
3 changes: 0 additions & 3 deletions packages/cmf/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,7 @@
}
},
"scripts": {
"build:dev": "talend-scripts build --umd --dev",
"build:prod": "talend-scripts build --umd --prod",
"build:lib:esm": "talend-scripts build --esm",
"pre-release": "yarn build:dev && yarn build:prod",
"build:lib": "talend-scripts build",
"start": "echo nothing to start",
"test": "talend-scripts test",
Expand Down
3 changes: 0 additions & 3 deletions packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@
},
"license": "Apache-2.0",
"scripts": {
"build:dev": "talend-scripts build --umd --dev",
"build:prod": "talend-scripts build --umd --prod",
"pre-release": "yarn build:dev && yarn build:prod",
"build:lib": "talend-scripts build && yarn run tsc",
"build:lib:esm": "talend-scripts build --esm",
"watch": "talend-scripts build --watch",
Expand Down
14 changes: 7 additions & 7 deletions ...mponents/src/DateTimePickers/DateRange/Picker/__snapshots__/Picker.component.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ exports[`DateRange.Picker should render 1`] = `
tabindex="-1"
type="button"
>
2022
2023
</button>
</li>
<li>
Expand All @@ -100,7 +100,7 @@ exports[`DateRange.Picker should render 1`] = `
tabindex="-1"
type="button"
>
2023
2024
</button>
</li>
<li>
Expand All @@ -109,7 +109,7 @@ exports[`DateRange.Picker should render 1`] = `
tabindex="-1"
type="button"
>
2024
2025
</button>
</li>
<li>
Expand All @@ -118,7 +118,7 @@ exports[`DateRange.Picker should render 1`] = `
tabindex="0"
type="button"
>
2025
2026
</button>
</li>
<li>
Expand All @@ -127,7 +127,7 @@ exports[`DateRange.Picker should render 1`] = `
tabindex="-1"
type="button"
>
2026
2027
</button>
</li>
<li>
Expand All @@ -136,7 +136,7 @@ exports[`DateRange.Picker should render 1`] = `
tabindex="-1"
type="button"
>
2027
2028
</button>
</li>
<li>
Expand All @@ -145,7 +145,7 @@ exports[`DateRange.Picker should render 1`] = `
tabindex="-1"
type="button"
>
2028
2029
</button>
</li>
</ol>
Expand Down
14 changes: 7 additions & 7 deletions packages/components/src/DateTimePickers/views/DateView/__snapshots__/DateView.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ exports[`DateView should render 1`] = `
tabindex="-1"
type="button"
>
2022
2023
</button>
</li>
<li>
Expand All @@ -118,7 +118,7 @@ exports[`DateView should render 1`] = `
tabindex="-1"
type="button"
>
2023
2024
</button>
</li>
<li>
Expand All @@ -127,7 +127,7 @@ exports[`DateView should render 1`] = `
tabindex="-1"
type="button"
>
2024
2025
</button>
</li>
<li>
Expand All @@ -136,7 +136,7 @@ exports[`DateView should render 1`] = `
tabindex="0"
type="button"
>
2025
2026
</button>
</li>
<li>
Expand All @@ -145,7 +145,7 @@ exports[`DateView should render 1`] = `
tabindex="-1"
type="button"
>
2026
2027
</button>
</li>
<li>
Expand All @@ -154,7 +154,7 @@ exports[`DateView should render 1`] = `
tabindex="-1"
type="button"
>
2027
2028
</button>
</li>
<li>
Expand All @@ -163,7 +163,7 @@ exports[`DateView should render 1`] = `
tabindex="-1"
type="button"
>
2028
2029
</button>
</li>
</ol>
Expand Down
3 changes: 0 additions & 3 deletions packages/containers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@
},
"license": "Apache-2.0",
"scripts": {
"build:dev": "talend-scripts build --umd --dev",
"build:prod": "talend-scripts build --umd --prod",
"pre-release": "yarn build:dev && yarn build:prod",
"build:lib": "talend-scripts build",
"build:lib:esm": "talend-scripts build --esm",
"start": "talend-scripts start-storybook -p 6007",
Expand Down
3 changes: 0 additions & 3 deletions packages/dataviz/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@
},
"license": "Apache-2.0",
"scripts": {
"pre-release": "yarn build:umd:dev && yarn build:umd:prod",
"build:umd:dev": "talend-scripts build --umd --dev",
"build:umd:prod": "talend-scripts build --umd",
"build:lib": "talend-scripts build",
"build:lib:esm": "talend-scripts build --esm",
"build-storybook": "talend-scripts build-storybook",
Expand Down
3 changes: 0 additions & 3 deletions packages/design-system/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,7 @@
},
"scripts": {
"build:lib": "talend-scripts build",
"build:lib:umd": "talend-scripts build --umd --dev",
"build:lib:umd:min": "talend-scripts build --umd --prod",
"build:lib:esm": "talend-scripts build --esm",
"pre-release": "npm run build:lib:umd && npm run build:lib:umd:min",
"watch": "talend-scripts build --watch",
"test": "talend-scripts test",
"extract-i18n": "i18next-scanner --config i18next-scanner.config.js",
Expand Down
8 changes: 3 additions & 5 deletions packages/design-tokens/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,11 @@
}
},
"scripts": {
"pre-release": "echo nothing",
"build:umd:dev": "talend-scripts build --umd --dev",
"build:umd:prod": "talend-scripts build --umd",
"build:lib": "talend-scripts build && yarn build:umd:dev && yarn build:umd:prod && yarn test:umd",
"build:lib": "talend-scripts build && npm run build:css",
"build:lib:esm": "talend-scripts build --esm",
"build:css": "sass src/index.scss dist/TalendDesignTokens.css --no-source-map --style=compressed",
"test": "echo no test for @talend/design-tokens",
"test:cov": "echo no test for @talend/design-tokens",
"test:umd": "jest scripts/umd.test.js",
"lint": "talend-scripts lint"
},
"keywords": [
Expand All @@ -57,6 +54,7 @@
"access": "public"
},
"devDependencies": {
"sass": "^1.93.2",
"@talend/eslint-config": "^13.5.0",
"@talend/eslint-plugin": "^1.6.0",
"@talend/scripts-core": "^16.8.0",
Expand Down
3 changes: 0 additions & 3 deletions packages/faceted-search-query-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@
},
"license": "Apache-2.0",
"scripts": {
"build:dev": "talend-scripts build --umd --dev",
"build:prod": "talend-scripts build --umd --prod",
"pre-release": "yarn build:dev && yarn build:prod",
"build:lib": "talend-scripts build",
"build:lib:esm": "talend-scripts build --esm",
"test": "cross-env TZ=UTC talend-scripts test",
Expand Down
3 changes: 0 additions & 3 deletions packages/faceted-search/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@
},
"license": "Apache-2.0",
"scripts": {
"build:dev": "talend-scripts build --umd --dev",
"build:prod": "talend-scripts build --umd --prod",
"pre-release": "yarn build:dev && yarn build:prod",
"build:lib": "talend-scripts build",
"build:lib:esm": "talend-scripts build --esm",
"test": "cross-env TZ=UTC talend-scripts test",
Expand Down
Loading