Skip to content

feat(script): remove cdn option #5667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
jmfrancois wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

feat(script): remove cdn option #5667

jmfrancois wants to merge 8 commits into from

Conversation

@jmfrancois
Copy link
Contributor

@jmfrancois jmfrancois commented Dec 23, 2025

What is the problem this PR is trying to solve?

What is the chosen solution to this problem?

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@changeset-bot
Copy link

changeset-bot bot commented Dec 23, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7a38bbb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe December 23, 2025 16:13 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe December 23, 2025 16:15 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe December 23, 2025 16:26 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe December 23, 2025 16:36 — with GitHub Actions Inactive
smouillour
smouillour reviewed Dec 23, 2025
View reviewed changes
fork/json-schema-form-core/package.json
},
"scripts": {
"build:lib": "rimraf dist && talend-scripts build --umd",
"build:lib:esm": "talend-scripts build --esm",
Copy link
Contributor

@smouillour smouillour Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no build lib without --umd? to align with other packages

packages/assets-api/src/index.ts
return `${CDN_URL}/${info.name}/${info.version}${info.path}`;
}
return `https://unpkg.com/${info.name}@${info.version}${info.path}`;
return `https://statics.cloud.talend.com/${info.name}/${info.version}${info.path}`;
Copy link
Contributor

@smouillour smouillour Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

packages/cmf-cqrs/package.json
"build:dev": "talend-scripts build --umd --dev",
"build:prod": "talend-scripts build --umd --prod",
"pre-release": "yarn build:dev && yarn build:prod",
"build:lib": "talend-scripts build",
Copy link
Contributor

@smouillour smouillour Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an esm version?

packages/flow-designer/package.json
"main": "lib/index.js",
"mainSrc": "src/index.js",
"scripts": {
"build:lib": "talend-scripts build",
Copy link
Contributor

@smouillour smouillour Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no esm build?

packages/http/package.json
"main": "lib/index.js",
"mainSrc": "src/index.ts",
"scripts": {
"build:lib": "talend-scripts build",
Copy link
Contributor

@smouillour smouillour Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no esm version?

packages/router-bridge/package.json
"build:dev": "talend-scripts build --umd --dev",
"build:prod": "talend-scripts build --umd --prod",
"pre-release": "yarn build:dev && yarn build:prod",
"build:lib": "talend-scripts build",
Copy link
Contributor

@smouillour smouillour Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no esm?

packages/router-bridge/package.json
"build:dev": "talend-scripts build --umd --dev",
"build:prod": "talend-scripts build --umd --prod",
"pre-release": "yarn build:dev && yarn build:prod",
"build:lib": "talend-scripts build",
Copy link
Contributor

@smouillour smouillour Dec 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no esm?

packages/sagas/package.json
"build:dev": "talend-scripts build --umd --dev",
"build:prod": "talend-scripts build --umd --prod",
"pre-release": "yarn build:dev && yarn build:prod",
"build:lib": "talend-scripts build",
Copy link
Contributor

@smouillour smouillour Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no esm?

packages/stepper/package.json
"build:dev": "talend-scripts build --umd --dev",
"build:prod": "talend-scripts build --umd --prod",
"pre-release": "yarn build:dev && yarn build:prod",
"build:lib": "talend-scripts build",
Copy link
Contributor

@smouillour smouillour Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no esm?

@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe December 23, 2025 16:50 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe December 23, 2025 17:06 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe December 23, 2025 17:06 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2025 •
edited
Loading

Title Lines Statements Branches Functions
assets-api Coverage: 28%
 28.4% (25/88) 30.76% (16/52) 21.42% (3/14)
cmf Coverage: 89%
 89.36% (1243/1391) 80.93% (607/750) 89.51% (350/391)
cmf-cqrs Coverage: 87%
 87.43% (160/183) 70.23% (59/84) 84.21% (48/57)
cmf-router Coverage: 70%
 69.23% (135/195) 55.71% (78/140) 56.81% (25/44)
components Coverage: 90%
 90.63% (5517/6087) 81.59% (3196/3917) 88.14% (1390/1577)
containers Coverage: 84%
 83.59% (1391/1664) 74.3% (694/934) 75% (327/436)
dataviz Coverage: 85%
 85.44% (323/378) 66.66% (160/240) 75.79% (119/157)
design-system Coverage: 67%
 66.49% (1016/1528) 50.93% (544/1068) 53.94% (219/406)
faceted-search Coverage: 85%
 85.08% (639/751) 78.63% (287/365) 81.88% (226/276)
flow-designer Coverage: 70%
 70.07% (651/929) 66.72% (355/532) 70.92% (200/282)
forms Coverage: 86%
 86.27% (1640/1901) 75.89% (929/1224) 85.02% (460/541)
http Coverage: 100%
 100% (85/85) 98.07% (51/52) 100% (34/34)
sagas Coverage: 92%
 92.3% (24/26) 66.66% (4/6) 50% (2/4)
stepper Coverage: 80%
 81.52% (150/184) 59.34% (54/91) 80.85% (38/47)
utils Coverage: 100%
 100% (73/73) 90.9% (10/11) 100% (24/24)

@jmfrancois jmfrancois deployed to pull_request_unsafe December 24, 2025 08:21 — with GitHub Actions Active
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe December 24, 2025 08:21 — with GitHub Actions Inactive
@jmfrancois jmfrancois temporarily deployed to pull_request_unsafe December 24, 2025 08:21 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

Storybook for this PR deployed on this github page

@mhuchet
Copy link
Contributor

mhuchet commented Dec 24, 2025

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smouillour smouillour smouillour left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jmfrancois @mhuchet @smouillour