Skip to content

Conversation

@BioCam
Copy link
Collaborator

@BioCam BioCam commented Dec 29, 2025

The gateway to advanced LLD, liquid height probing, volume probing, foam detection, ... :)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR exposes advanced pressure-based liquid level detection (pLLD) controls through a new PXZE command wrapper, enabling features like liquid height probing, volume probing, and foam detection. The implementation adds comprehensive support for configuring both pressure LLD and optional capacitive LLD (cLLD) parameters.

Key Changes:

  • Introduced PressureLLDMode enum for liquid vs. foam detection modes
  • Added dispensing drive unit conversion utilities (volume ↔ mm ↔ increments)
  • Implemented move_tip_to_liquid_surface_using_plld_and_optional_clld() method with extensive parameter validation
Comments suppressed due to low confidence (1)

pylabrobot/liquid_handling/backends/hamilton/STAR_backend.py:1

  • Missing space before 'and' in the assertion error message. Should be f" and {STARBackend.z_drive_increment_to_mm(15_000)}"
import asyncio

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rickwierenga
Copy link
Member

because the clld measurement can't be quried, calling it "dual" probing is weird imo, it's just "extra check". maybe call it _plld_probe_z_height with parameter clld_verification_using_channel?

@rickwierenga
Copy link
Member

renamed the low level firmware method to _search_for_surface_using_plld to differentiate it more clearly from plld_probe_z_height_using_channel (which has more features like the other probe methods, which depend on C0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants