Skip to content

fix: timeline animation error #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MakinoharaShoko merged 1 commit into from
Feb 6, 2026
Merged

fix: timeline animation error #861

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/webgal/src/Core/controller/stage/pixi/animations/timeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ export function generateTimelineObj(
}
const container = target?.pixiContainer;
let animateInstance: ReturnType<typeof popmotion.animate> | null = null;
// 只有有 duration 的时候才有动画
if (duration > 0) {
// 只有有 duration 且 timeline 长度大于 1 的时候才有动画
if (duration > 0 && timeline.length > 1) {
Copy link

@gemini-code-assist gemini-code-assist bot Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

这个条件很好地解决了只有一个关键帧时创建动画的问题。然而，我注意到一个相关的边界情况：当 timeline 数组为空时，此函数将在第 64 行因试图解构 undefined 而崩溃。虽然这可能超出了本次修复的范围，但为了增强函数的健壮性，建议在函数开头添加一个检查来处理空时间轴的情况，例如：

if (timeline.length === 0) {
  // 返回一个无操作的动画对象或直接返回
  return {
    setStartState: () => {},
    setEndState: () => {},
    tickerFunc: () => {},
    getEndStateEffect: () => ({}),
    forceStopWithoutSetEndState: () => {},
  };
}

animateInstance = popmotion.animate({
to: values,
offset: times,
Expand Down