Skip to content

Fix: Persist missing object removal when uploading matching object #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
Closed

Fix: Persist missing object removal when uploading matching object #229

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e66a97
Initial plan
Copilot Jan 11, 2026
622ed2d
Fix: Persist missing object removal on early return in CreateDatAsync
Copilot Jan 11, 2026
8120f7b
Optimize: Only call SaveChangesAsync when a missing entry was actuall…
Copilot Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ObjectService/RouteHandlers/TableHandlers/ObjectRouteHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,12 @@ static async Task<IResult> CreateDatAsync(DtoObjectPost request, [FromServices]
if (db.DoesObjectExist(hdrs.S5.Name, hdrs.S5.Checksum, out var existingObject))
{
// todo: if we get here - the object doesn't exist but the dat object does - we should then link them
// save changes first to persist any missing object removal
if (missingEntry != null)
{
_ = await db.SaveChangesAsync();
}

return Results.Accepted($"Object already exists in the database. DatName={hdrs.S5.Name} DatChecksum={hdrs.S5.Checksum} UploadedDate={existingObject!.UploadedDate}");
}

Expand Down