Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 11, 2026

When an object is uploaded that matches an entry in TblObjectMissing (by DatName and DatChecksum), the missing entry was removed from the change tracker but not persisted due to an early return path that skipped SaveChangesAsync().

Changes

  • Added conditional SaveChangesAsync() call before early return in CreateDatAsync when a missing entry was removed
  • Only triggers database round-trip when an entry was actually found and removed
if (db.DoesObjectExist(hdrs.S5.Name, hdrs.S5.Checksum, out var existingObject))
{
    if (missingEntry != null)
    {
        _ = await db.SaveChangesAsync();
    }
    return Results.Accepted(...);
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • av-build-tel-api-v1.avaloniaui.net
    • Triggering command: /usr/share/dotnet/dotnet dotnet exec --runtimeconfig /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.1/tools/netstandard2.0/runtimeconfig.json /home/REDACTED/.nuget/packages/avalonia.buildservices/11.3.1/tools/netstandard2.0/Avalonia.BuildServices.Collector.dll (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>If an object is uploaded to the server that is listed as missing, it gets resolved/marked as available</issue_title>
<issue_description>Objects founds in the TblObjectsMissing table are referred to as missing objects. If someone uploads an object to the /objects route that exists in /objects/missing, the entry from TblObjectsMissing should be removed</issue_description>

<agent_instructions>Objects founds in the TblObjectMissing table are referred to as missing objects. If someone uploads an object to the /objects route (handled by ObjectRouteHandler class) that exists in TblObjectsMissing (this would be an object with matching dat name and checksum to an entry in TblObjectsMissing) then the entry should be removed from TblObjectsMissing (as it is no longer missing - it was just uploaded!</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits January 11, 2026 13:36
Co-authored-by: LeftofZen <7483209+LeftofZen@users.noreply.github.com>
…y removed

Co-authored-by: LeftofZen <7483209+LeftofZen@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issue of marking uploaded objects as available Fix: Persist missing object removal when uploading matching object Jan 11, 2026
Copilot AI requested a review from LeftofZen January 11, 2026 13:44
@LeftofZen LeftofZen closed this Jan 13, 2026
@LeftofZen LeftofZen deleted the copilot/fix-missing-objects-upload branch January 13, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If an object is uploaded to the server that is listed as missing, it gets resolved/marked as available

2 participants