fix types: allow blockTracker to be any BlockTracker#76
Merged
legobeat merged 1 commit intoMetaMask:mainfrom May 28, 2024
Merged
fix types: allow blockTracker to be any BlockTracker#76legobeat merged 1 commit intoMetaMask:mainfrom
legobeat merged 1 commit intoMetaMask:mainfrom
Conversation
legobeat
force-pushed
the
type-blocktracker
branch
from
3911153 to
2bc0810
Compare
Mrtenz
approved these changes
May 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constructor option is narrowly typed to the class
PollingBlockTracker, which adds considerable ergonomic friction (only the exact same class instance will pass typing) for no apparent reason.This widens the interface to allow any
BlockTracker. This is not a breaking change.Related
Blocked by