Merged
Conversation
legobeat
force-pushed
the
dynamic-provider-private-props
branch
from
bc4ecce to
3de3044
Compare
If anyone would ever update the provider, they must also update the blockTracker
legobeat
force-pushed
the
dynamic-provider-private-props
branch
from
3de3044 to
734129a
Compare
legobeat
requested review from
a team,
OGPoyraz,
kumavis,
matthewwalsh0 and
vinistevam
1 task
Mrtenz
approved these changes
May 28, 2024
Member
Mrtenz
left a comment
Mrtenz
left a comment
There was a problem hiding this comment.
This is technically a breaking change, right? Looks good to me though.
legobeat
commented
May 28, 2024
| * @param opts.provider - An ethereum provider | ||
| * @param opts.blockTracker - An instance of @metamask/eth-block-tracker | ||
| */ | ||
| setProvider({ |
Contributor
Author
There was a problem hiding this comment.
I am very easily convinced to remove the setProvider function alltogether, if there is no current use for it. Put it in to make sure there are no compatibility concerns by default.
Contributor
Author
|
@Mrtenz Indeed, and intended to be released as such. |
dbrans
reviewed
Jun 6, 2024
Comment on lines
-211
to
+230
| const blockNumber = await this.blockTracker.getLatestBlock(); | ||
| const baseCount: number = await this.web3.getTransactionCount( | ||
| address, | ||
| blockNumber, | ||
| ); | ||
| const blockNumber = await this.#blockTracker.getLatestBlock(); | ||
| const baseCount: number = await new Web3Provider( | ||
| this.#provider, | ||
| ).getTransactionCount(address, blockNumber); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
web3propertyreadonlysetProviderfunction which allows atomically setting the provider and block tracker on an existing instance.Should remove the need for this patch in MM extension.
Blocking