Skip to content

BUGFIX: Find nodes in CR without security checks to allow nodes of other workspaces #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gradinarufelix wants to merge 2 commits into
base: 8.0
Choose a base branch
from
Open

BUGFIX: Find nodes in CR without security checks to allow nodes of other workspaces #423

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ea253c
BUGFIX: Find nodes in CR without security checks to allow nodes of ot…
gradinarufelix Jan 26, 2026
21e9331
BUGFIX: Use reference variable for withoutAuthorizationChecks callbac…
gradinarufelix Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion Classes/Indexer/NodeIndexer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
use Neos\ContentRepository\Search\Indexer\AbstractNodeIndexer;
use Neos\ContentRepository\Search\Indexer\BulkNodeIndexerInterface;
use Neos\Flow\Annotations as Flow;
use Neos\Flow\Security\Context as SecurityContext;
use Neos\Utility\Exception\FilesException;
use Neos\Flow\Log\Utility\LogEnvironment;
use Psr\Log\LoggerInterface;
Expand Down Expand Up @@ -145,6 +146,12 @@ class NodeIndexer extends AbstractNodeIndexer implements BulkNodeIndexerInterfac
*/
protected $errorStorage;

/**
* @Flow\Inject
* @var SecurityContext
*/
protected $securityContext;

/**
* The current Elasticsearch bulk request, in the format required by https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-bulk.html
*/
Expand Down Expand Up @@ -270,7 +277,12 @@ public function indexNode(NodeInterface $node, $targetWorkspace = null): void
};

$handleNode = function (NodeInterface $node, Context $context) use ($targetWorkspace, $indexer) {
$nodeFromContext = $context->getNodeByIdentifier($node->getIdentifier());
$nodeFromContext = null;
$this->securityContext->withoutAuthorizationChecks(
function () use ($context, $node, &$nodeFromContext) {
$nodeFromContext = $context->getNodeByIdentifier($node->getIdentifier());
}
);
if ($nodeFromContext instanceof NodeInterface) {
$this->searchClient->withDimensions(static function () use ($indexer, $nodeFromContext, $targetWorkspace) {
$indexer($nodeFromContext, $targetWorkspace);
Expand Down