BUGFIX: Find nodes in CR without security checks to allow nodes of other workspaces #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her workspaces Backport of Flowpack#419 to Neos 8.x This wraps the getNodeByIdentifier() call in withoutAuthorizationChecks() to prevent workspace-related authorization checks from failing when indexing nodes that exist in different workspaces. Resolves the error: Node workspace "user-xxx" not found in allowed workspaces (live), this could result from a detached workspace entity in the context.
…k result Flow's SecurityContext::withoutAuthorizationChecks() has a void return type and does not return the callback result. The previous implementation assumed the return value would be passed through, causing $nodeFromContext to always be null and preventing any nodes from being indexed. This fix captures the result via a reference variable instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #419 to Neos 8.x
This wraps the getNodeByIdentifier() call in withoutAuthorizationChecks() to prevent workspace-related authorization checks from failing when indexing nodes that exist in different workspaces.
Resolves the error: Node workspace "user-xxx" not found in allowed workspaces (live), this could result from a detached workspace entity in the context.