Simplify branching in command functions #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes `get_board/motor_temperatures` functions ignoring their `timeout` parameter.
Contributor
Author
|
Hi @cpr-bar, happy new year! I implemented some of the refactoring we discussed in December. If we can get this merged I can proceed with context manager or async refactoring. |
Collaborator
|
Hi @michaelosthege and also a happy new year, thanks for the simplifications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_send_commandnever returnsNone, therefore many branches were unreachable_wait_for_answerto acceptmessage_idasstr | int, making it easier to call_wait_for_answerwithtimeout: float | None = DEFAULTsuch that the runtime-configurableDEFAULT_ANSWER_TIMEOUTis used by default.