Skip to content

Conversation

@MaxMansfield
Copy link
Collaborator


name: Pull Request
about: Submit changes to the RTMS SDK

Description

The publish:js task had deps on prebuild:js which triggered a full rebuild during CI publish. This failed because the SDK isn't installed in the publish job - it only downloads pre-built artifacts.

Removed build dependencies from publish tasks since CI handles the build/publish separation. Added :full variants for local development where the full build→publish flow is needed.

Related Issues

Fixes #(issue number)

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Tests (adding or improving tests)
  • Build changes

Affected Components

  • Core C++ implementation
  • Node.js bindings
  • Python bindings
  • Go bindings
  • Build system
  • Documentation
  • Examples
  • Other (please specify)

Testing Performed

Describe the tests you ran to verify your changes. Include relevant details such as test configuration and instructions to reproduce.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Additional Context

Add any other context about the PR here.

The publish:js task had deps on prebuild:js which triggered a full
rebuild during CI publish. This failed because the SDK isn't installed
in the publish job - it only downloads pre-built artifacts.

Removed build dependencies from publish tasks since CI handles the
build/publish separation. Added :full variants for local development
where the full build→publish flow is needed.
@MaxMansfield MaxMansfield merged commit 2da0d48 into main Jan 27, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants