Updated script to work with Python 2.7 and Python 3#1
Open
tolap22 wants to merge 2 commits intoziyan:masterfrom
Open
Updated script to work with Python 2.7 and Python 3#1tolap22 wants to merge 2 commits intoziyan:masterfrom
tolap22 wants to merge 2 commits intoziyan:masterfrom
Conversation
…ndency and with default fallback if something fails
…lation instructions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the ssh-otp.py script to ensure compatibility with both Python 2.7 and Python 3, removing the dependency on the yaml library. The script now uses a minimal internal YAML loader/dumper for configuration, and includes a default fallback mechanism if configuration loading fails.
Details:
Ensures the script runs seamlessly on both Python 2.7 and Python 3.
Removes the need for the external yaml dependency.
Adds a minimal YAML parser and dumper within the script for basic key-value configuration.
Implements a default configuration fallback if loading fails, improving robustness.
Updated QRCode URL which had been discontinued
No changes to the user-facing interface or command-line usage.
Motivation:
This change improves portability and ease of use, especially on systems where installing extra Python dependencies is not desirable or possible.