fix: createMonsterType memory leak #557
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential Memory Leak
lua_error(L)mid-execution. If the Lua/C++ environment is not configured to unwind the C++ stack during a Lua error (which useslongjmp), the destructors of the local objects (std::shared_ptr<MonsterType>,std::set,std::string) would not be called.MonsterTypeand for the strings/sets.Inconsistent State
lua_error.The result would be a "half-registered" monster in the system, but the Lua script would receive an error and stop, leaving the server in a dirty state.