-
Notifications
You must be signed in to change notification settings - Fork 314
Pydantic v2 Migration, Weaviate v4 Upgrade, and UI Fixes #674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ibility. Update weaviate client to use new v4.18.3 API. Minor fixes on CLI
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fer-marino The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
mark it as draft please. There is still more pydantic work to do. |
… for backward compatibility. Update MariaDB and PostgreSQL HNSW configs with defaults. Simplify MariaDB table creation logic. Upgrade weaviate client to v4.18.3.
…cleanup unused formatting.
…o >=1.52.2 and Pydantic to >=2.
|
@fer-marino great work! Please notify me if it's ready to review |
|
this is ready for review. Anyway I've noticed that many test units fail. I'm not sure it depends on my code changes. It looks some are just outdated. |
Description
This pull request implements a significant modernization of the codebase, primarily focusing on the migration to Pydantic v2 and upgrading the Weaviate client to v4.18.x. It also includes backward compatibility patches for existing benchmark results and addresses UI deprecation warnings.
Key Changes
1. Pydantic v2 Migration
field_validatorand improvedValidationErrorhandling frompydantic_core.SecretStrfor sensitive connection details (passwords, API keys) across all database clients.2. Weaviate Client Upgrade (v3.x → v4.18.x)
WeaviateCloudclient to use the new Weaviate v4 "Collections" API.weaviate.connect_to_custom, utilizing both HTTP and gRPC endpoints for improved performance.weaviate.classes.configand fluent interface.WeaviateCloud._ensure_cfgto support both legacy dict configurations and newWeaviateConfigmodels.3. Backward Compatibility & Stability
TestResult.read_fileto inject default credentials (e.g.,password: "-") for MariaDB, PgVector, and Weaviate when loading older result files. This preventsValidationErrorwhen viewing historical data that omitted these fields.db.case_config_clsinstantiation to ensure that a single malformed result file doesn't prevent the results page from loading.4. Streamlit UI Updates
use_container_width=Truewithwidth="stretch"across all chart and table components.Verification Results
stretchparameter.