Removed need for deprecated GET_TASKS permission#65
Open
dwb wants to merge 4 commits intozetavg:masterfrom
Open
Removed need for deprecated GET_TASKS permission#65dwb wants to merge 4 commits intozetavg:masterfrom
dwb wants to merge 4 commits intozetavg:masterfrom
Conversation
added 4 commits
August 23, 2016 16:24
Rewritten notification-click intent handling so that we don't need to check whether app is running or not. Instead, it sends the intent such that it can get an 'OK' response back if the app is running; if not, it'll start the app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewritten notification-click intent handling so that we don't need to
check whether app is running or not. Instead, it sends the intent such
that it can get an 'OK' response back if the app is running; if not,
it'll start the app.
getRunningTasks was deprecated in Lollipop, as was the whole GET_TASKS permission.
This is the first significant Android code I've written, so apologies if
it's not quite right – but it's been working for us in low-volume testing
recently.