Fixed a bug in the identity map decorator if no object is found by getRelatedObject()#1
Open
schaumiii wants to merge 7 commits intozetacomponents:masterfrom
Open
Conversation
The normal ezcPersistentSession object throws an ezcPersistentRelatedObjectNotFoundException if getRelatedObject() did not found any related object, but the Decorator does not. This problem was fixed here.
src/session_decorators/identity.php
Outdated
There was a problem hiding this comment.
To remove this comment is wrong -- it still can throw this exception ;-)
Member
|
I suppose this didn't break any other tests? |
…ded person in test-enviroment
this is needed because we do not expect them to be found
This class relies on the fact that zetaComponents were installed by PEAR or are directly accessible from the include path. This was fixed and the implementation in this directories are used now.
Contributor
Author
|
No sorry, I unfortunately did not run the whole testsuite, but did now and fixed all other tests to be compatible with the new database entry. I also needed to change the require statement in one class and opened #2 for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ezcPersistentSessionobject throws anezcPersistentRelatedObjectNotFoundExceptionifgetRelatedObject()did not found any related object, but the Decorator does not.This problem was fixed here and the decorator now behaves like
ezcPersistentSessiondoes.