Skip to content

Conversation

@HookedBehemoth
Copy link
Contributor

@HookedBehemoth HookedBehemoth commented Jun 28, 2022

Closes #646
My first draft so far with a few issues here and there to fix:

  • inlineStyles are applied to entire paragraphs (is it guaranteed that these don't overlap with links and media?)
  • hashtags/@ aren't linked to
  • unicode characters are badly handled in paragraphs with links¹
  • embeds have the wrong size² (see Dynamic blockquote.twitter-tweet embeds #586 (comment)) (out of scope; directly embedding requires multiple requests)
  • alt text on images isn't set

Not implemented (yet):

Some screenshots

(1)

(2)

@HookedBehemoth HookedBehemoth force-pushed the feature-notes branch 2 times, most recently from 76c930e to 63bb30e Compare June 28, 2022 13:01
@HookedBehemoth
Copy link
Contributor Author

Should I bump the style sheet version parameter?

@zedeus
Copy link
Owner

zedeus commented Jul 1, 2022

Yes, it invalidates the browser cache

@HookedBehemoth HookedBehemoth requested a review from zedeus July 23, 2022 12:45
x86pup added a commit to x86pup/nitter that referenced this pull request Dec 21, 2022
Signed-off-by: r3g_5z <june@girlboss.ceo>
x86pup added a commit to x86pup/nitter that referenced this pull request Jan 21, 2023
Signed-off-by: r3g_5z <june@girlboss.ceo>
@HookedBehemoth HookedBehemoth changed the title initial notes support Notes support Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Twitter Notes

2 participants