-
Notifications
You must be signed in to change notification settings - Fork 1
build: major dependencies update #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request updates the project's dependencies and build configurations. It migrates from Singularity to Apptainer, updates Conda environment configurations, and adjusts CI workflows to use Miniforge. The changes also include updating dependency embedding strategies and supported Python versions. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @uniqueg - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a dependabot configuration file to automate dependency updates.
- The switch from Singularity to Apptainer is a breaking change that should be communicated clearly to users.
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #97 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 1263 1263
=========================================
Hits 1263 1263 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes #94
Further fixes additional issues addressed in zavolanlab/zarp#181
Type of change
to not work as expected)
Checklist
warnings
have added type annotations for any local variables that are non-trivial,
potentially ambiguous or might otherwise benefit from explicit typing.
docstrings
to all new modules, classes,
methods/functions or updated previously existing ones
works
reduced the code coverage relative to the previous state
by the proposed changes
Breaking changes
APPTAINERinstead ofSINGULARITYSummary by Sourcery
Update project dependencies, CI workflows, and replace Singularity with Apptainer for container management
New Features:
Enhancements:
Build:
CI: