-
Notifications
You must be signed in to change notification settings - Fork 0
chore: Depend on most recent Swift SDK version and update breaking changes #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Greptile SummaryThis PR updates the React Native SDK to depend on Swift SDK version 1.0.1 (from 0.1.0), introducing several breaking changes to align with the new API interface. Major Breaking Changes
All changes are consistently applied across TypeScript types, Swift implementations, tests, mocks, and the example app. Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant App as React Native App
participant Module as YV Platform Module
participant Auth as YVPAuthAPI
participant SDK as Swift SDK v1.0.1
participant User as End User
Note over App,SDK: Sign In Flow Changes
App->>Module: signIn with permissions
Module->>Auth: Process sign in
Auth->>SDK: Call signIn API
SDK->>User: OAuth flow
User-->>SDK: Authenticates
SDK-->>Auth: Return auth result
Auth-->>Module: Map to JS object
Module-->>App: Return result with new fields
Note over App,SDK: User Info Flow Changes
App->>Module: Request user info
Module->>Auth: Get user info
Note over Auth,SDK: Changed to synchronous
Auth->>SDK: Read static properties
SDK-->>Auth: Return user data
Auth-->>Module: Map with renamed fields
Module-->>App: Return user info
Note over App,SDK: Bible Text Interaction Changes
App->>Module: Render BibleTextView
Module->>SDK: Display text
User->>SDK: Tap verse
SDK-->>Module: Callback with new params
Module-->>App: Event with urlScheme
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9 files reviewed, 1 comment
04f0ed8 to
1e358e6
Compare
This will be temporary until we figure out how to create a representation of footnotes that can be cross platform.
1e358e6 to
e501b37
Compare
mic-mart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @sidorchukandrew !
## 0.8.0 (2026-01-16) * chore: Depend on most recent Swift SDK version and update breaking changes (#27) ([a042211](a042211)), closes [#27](#27) * chore(ci): Disable NPM tokens in release workflow (#28) ([c63c21a](c63c21a)), closes [#28](#28) * chore(ci): update semantic-release to support OIDC workflow (#29) ([de337dc](de337dc)), closes [#29](#29) * chore(ci): YPE-1050 Modify release.yml for permissions and Node.js version ([2c86c6f](2c86c6f)) * Add NODE_AUTH_TOKEN to release workflow ([2bdc89c](2bdc89c)) * Add provenance option to npm release configuration ([d746acf](d746acf)) * Enable NPM_CONFIG_PROVENANCE in release workflow ([e027853](e027853)) * Update Node.js version and add NPM upgrade step ([ee94aa2](ee94aa2)) * feat: add support for `configure` in Kotlin (#16) ([d9bca2d](d9bca2d)), closes [#16](#16) * feat: implement `setApiHost` and `getAccessToken` in Kotlin (#17) ([a4ee43c](a4ee43c)), closes [#17](#17) * feat: Implement `SignInWithYouVersionButton` for Kotlin (#26) ([5072471](5072471)), closes [#26](#26) * feat: Implement API utils for Kotlin/Android (#25) ([9a88926](9a88926)), closes [#25](#25) * feat: implement votd API endpoint for Kotlin (#19) ([59e6874](59e6874)), closes [#19](#19) * docs: add AI agent code review guidelines (#23) ([8218cec](8218cec)), closes [#23](#23)
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR updates the version of the Swift SDK we're depending on. With this update, there are a number of changes that needed to be made to match the new API interface.
Type of Change
feat:New feature (non-breaking change which adds functionality)fix:Bug fix (non-breaking change which fixes an issue)docs:Documentation updaterefactor:Code refactoring (no functional changes)perf:Performance improvementtest:Test additions or updatesbuild:Build system or dependency changesci:CI configuration changeschore:Other changes (maintenance, etc.)Breaking Changes
Breaking Change Details:
The Swift SDK updates introduced a number of changes to field names. This is reflected in the modifications I made to the types file.
Checklist